Re: [PATCH] Fix fix false positive "Misconfiguration in the phone table detected."

[Daniele Forsi]

Il giorno sab 21 nov 2020 alle ore 10:06 Ladislav Michl ha scritto:

> > Did you test this change? Please don't change the code that you can test.
>
> Yes, I was able at least to read something on C2-OO, but still working
> on full support.

maybe we could add a short note "tested with ... phone" for the future

> Ah! Then I'm suggesting to add a little comment like that above such
> checks :)

yes, indeed, it's a debug string that average users won't see but
maybe something like this would be useful for developers:
"Please help to make libgnokii better sending the following information to..."

or suggest what you would have found helpful, in short:
libgnokii tried a command that failed, then tried another command that
succeeded, we can modify libgnokii to avoid sending the command that
failed

maybe we should use an helper function instead of having 6 instances
of the line dprintf("Misconfiguration...

thank you
-- 
Daniele Forsi