Re: devices: pass gn_config to open and following devices: *: use instance data commits

[Ladislav Michl]

Ah, I see now.

I was unsure about removing gn_config entirely, so I decided to pass it
as parameter. After all it is device configuration, so I guess it does
belong there.

usbfbus_find_interfaces by its name just finds interface, no need to
clutted it with unrelated stuff...

        ladis

-----Original Message-----
From: Pawel Kot <gnokii@gmail.com>
To: Ladislav Michl <ladis@triops.cz>
Cc: Ladislav Michl <ladis@linux-mips.org>, Discussion forum for gnokii
users. <gnokii-users@nongnu.org>
Subject: Re: devices: pass gn_config to open and following devices: *:
use instance data commits
Date: Sun, 9 Jan 2022 22:01:37 +0100

Hi Ladis,

Thanks. Let me look into preview5 shortly then.

Why bother with gn_config then? As far as I can see all drivers use
just ->port_device. (Plus two more by bluetooth). So perhaps let's
kill this dependency as well?

I mean this part:
https://github.com/3x380V/gnokii/commit/fcbe237d1c18b499a1a5992130146edb07f4f0f2#diff-eda4a60c956c0ae338299217d26f32a0a34ad79e14ddbfab08594a4cbfdc5d64
You have moved the n = atoi(cfg->port_device) portion from one function
to the other.

Cheers,
Paweł