[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gnuastro-commits] master 56b7953e: color-faint-gray: test in make check
From: |
Mohammad Akhlaghi |
Subject: |
[gnuastro-commits] master 56b7953e: color-faint-gray: test in make check ignored when libjpeg not found |
Date: |
Fri, 7 Jun 2024 19:54:53 -0400 (EDT) |
branch: master
commit 56b7953e0af9059aecefef694c20c43819ef1435
Author: Mohammad Akhlaghi <mohammad@akhlaghi.org>
Commit: Mohammad Akhlaghi <mohammad@akhlaghi.org>
color-faint-gray: test in make check ignored when libjpeg not found
Until now, when libjpeg was not available, the 'mack check' test for
astscript-color-faint-gray would FAIL because its output is a JPEG file,
but it did not have a check for libjpeg.
With this commit, the necessary check has been added so this test is
correctly SKIPped instead of FAILing.
This bug was reported by Takashi Ichikawa.
This fixes bug #65847.
---
NEWS | 3 +++
doc/announce-acknowledge.txt | 1 +
tests/script/color-faint-gray.sh | 1 +
3 files changed, 5 insertions(+)
diff --git a/NEWS b/NEWS
index 391c4d26..c3aab97d 100644
--- a/NEWS
+++ b/NEWS
@@ -205,6 +205,9 @@ See the end of the file for license conditions.
- bug #65833: Convolve crashes when the kernel only has a single element.
+ - bug #65847: make check FAILs on color-faint-gray script when libjpeg
+ not found. Reported by Takashi Ichikawa.
+
diff --git a/doc/announce-acknowledge.txt b/doc/announce-acknowledge.txt
index 580b5e01..896791a8 100644
--- a/doc/announce-acknowledge.txt
+++ b/doc/announce-acknowledge.txt
@@ -13,6 +13,7 @@ Phil Wyett
Rahna Payyasseri Thanduparackal
Raul Infante-Sainz
Sepideh Eskandarlou
+Takashi Ichikawa
Zahra Sharbaf
diff --git a/tests/script/color-faint-gray.sh b/tests/script/color-faint-gray.sh
index dc4948b5..c7ccec0c 100755
--- a/tests/script/color-faint-gray.sh
+++ b/tests/script/color-faint-gray.sh
@@ -52,6 +52,7 @@ if [ ! -f $dep3name ]; then echo "$dep3name doesn't exist.";
exit 77; fi
if [ ! -f $dep4name ]; then echo "$dep4name doesn't exist."; exit 77; fi
if [ ! -f $dep5name ]; then echo "$dep5name doesn't exist."; exit 77; fi
if [ ! -f $fits1name ]; then echo "$fits1name doesn't exist."; exit 77; fi
+if [ "x$haslibjpeg" != "xyes" ];then echo "libjpeg not present."; exit 77;fi
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [gnuastro-commits] master 56b7953e: color-faint-gray: test in make check ignored when libjpeg not found,
Mohammad Akhlaghi <=