[gnuastro-devel] [bug #48657] Incorrect error messages in convolve.c

[Mohammad Akhlaghi]

Update of bug #48657 (project gnuastro):

                  Status:             In Progress => Fixed                  
             Open/Closed:                    Open => Closed                 

    _______________________________________________________

Follow-up Comment #3:

Great! Thanks! It is now merged with master and pushed to the main repo ;-).

Just one point: when breaking the arguments of a function into multiple lines,
we start the next line immediately under the opening parenthesis of the
function. For example, in the current implementation, the new line is started
like below:


    error(EXIT_FAILURE, errno, "%lu bytes for pimg",
                  2*ps0*ps1*sizeof *pimg);


It would be better if it was like this:


    error(EXIT_FAILURE, errno, "%lu bytes for pimg",
          2*ps0*ps1*sizeof *pimg);


I have corrected these in a subsequent commit along with some other cases of
lines that were too long. 

While making these corrections, I noticed that there was a TAB character at
the start of these lines. To make the source code view consistent on any local
or web text editor, we have adopted the convention of not using TABs for
indentation. So it would be great if you could also avoid TABs in the future
;-).

By the way, to display code nicely in Savannah, you can see the Savannah
markup here:

https://savannah.gnu.org/cookbook/?func=detailitem&item_id=125

In short you can put the code within two lines of '' and ''.

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?48657>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/