[gnuastro-devel] [task #14318] ImgCrop does not create the output image when the center is blank

[Mohammad Akhlaghi]

Follow-up Comment #1, task #14318 (project gnuastro):

Thanks, you are right!

Ideally checking the center of a crop is useful when the user has defined the
crop with a center (for example through a catalog, or the `--xc', `--yc',
`--ra', or `--dec' options). But currently this center check is applied to any
cropped region, for example even when the user specifies the cropped region
with `--section' or `--polygon'.

So what do think about this list of actions to do with this task? 

* Only check the center when the user has defined the crop by its center
coordinates (not in `--polygon' or `--section' mode).

* Set the default `--checkcenter' value to 0. In this case, no check will be
done even if the user gaves a center to define the crop. From the principle of
least astonishment
<https://en.wikipedia.org/wiki/Principle_of_least_astonishment>, the user
would expect a cropped file even if its blank. Also the user might want to go
through the files with a loop and having some missing numbers can mess up
their work. If the user asks for any value larger than 0, then we will check
the center (and not make an output file) when a center coordinate was input.

* When a crop is blank in the center and no file is created, let the user know
through a less cryptic way (currently its just the last `0' or `1' in the
stdout and in the log file). For example explicity writing `created' or
`not-created' (since the first column is the file name).

    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/task/?14318>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/