[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[bug #60923] Standard deviation returning NaN
From: |
Mohammad Akhlaghi |
Subject: |
[bug #60923] Standard deviation returning NaN |
Date: |
Fri, 16 Jul 2021 09:06:25 -0400 (EDT) |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Firefox/90.0 |
Update of bug #60923 (project gnuastro):
Status: None => Fixed
Open/Closed: Open => Closed
_______________________________________________________
Follow-up Comment #1:
Thanks a lot Natáli, it has been merged in Commit 35c14b7db28
<http://git.savannah.gnu.org/cgit/gnuastro.git/commit/?id=35c14b7db28>. Just
some points:
1. In the 'gal_statistics_mean_std' function, the value should have been
written into 'o[1]' (the mean is written in 'o[0]'). I fixed this in your
commit.
2. When describing the problem in comments give a specific description of what
caused problem. When you simply say "floating point errors", it is very vague.
But if you say the points are all equal except for floating point errors, it
becomes much more clear.
3. In comments or the commit message, when you are using code snippets within
English writing, put them within a single quote, for example in point one
above.
I have fixed all of these in the merged commit, but its good to have them in
mind for the future ;-).
Thanks again for finding and fixing this problem.
_______________________________________________________
Reply to this item at:
<https://savannah.gnu.org/bugs/?60923>
_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/