[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] [Amended] Replace proprietary EC installation recommendation
|
From: |
Denis 'GNUtoo' Carikli |
|
Subject: |
Re: [PATCH] [Amended] Replace proprietary EC installation recommendation with general EC information. Update to GNU boot in some places. Update battery recall information (the linked sites are no longer online and don't show anything without proprietary JS (plus they don't list any useful information like what battery batches are defective)). Update virtualization information. Update x201 case information. |
|
Date: |
Mon, 28 Apr 2025 19:44:00 +0200 |
Hi,
Sorry for the delay.
On Fri, 25 Apr 2025 19:18:29 +1000
DiffieHellman via Gnuboot-patches <gnuboot-patches@gnu.org> wrote:
> Subject: [PATCH] [Amended] Replace proprietary EC installation
> recommendation with general EC information. Update to GNU boot in
> some places. Update battery recall information (the linked sites are
> no longer online and don't show anything without proprietary JS
> (plus they don't list any useful information like what battery
> batches are defective)). Update virtualization information. Update
> x201 case information.
This patch need to be split in multiple patches as it has too many
unrelated changes. On the top of my head here are good reasons to split:
- Not splitting makes it hard to review since different things are mixed
together. Once split we can also discuss a given patch more easily
and people can see where the discussion happens.
- If we need to revert one of the changes, it would revert everything.
- If one of the changes isn't accepted if it is split, all the rest
can go in independently more easily.
It could be split in this way:
- website: docs: hardware: Replace proprietary EC installation
recommendation with general EC information.
- website: docs: hardware: Update to GNU boot in some places.
- website: docs: hardware: Update battery recall information
The linked sites are no longer online and don't show anything
without proprietary JS plus they don't list any useful information
like what battery batches are defective)).
- website: docs: hardware: Update virtualization information.
- website: docs: hardware: Update x201 case information.
Denis.
pgpHaIyCpDS9D.pgp
Description: OpenPGP digital signature