Re: [gnugo-devel] 100 game series

[Daniel Bump]

> One game, match078.sgf is misscored by W. The error
> is reproducible since --score last reports a 7.5
> win by W. There is actually a 7.5 point win by B.
> I'll investigate this later. The sgf file is
> attached.

The scoring error was caused by a bug introduced in
close_bubbles when score.c was converted it to 1D.

Dan

Index: engine/score.c
===================================================================
RCS file: /cvsroot/gnugo/gnugo/engine/score.c,v
retrieving revision 1.10
diff -u -r1.10 score.c
--- engine/score.c      2 Feb 2002 19:05:12 -0000       1.10
+++ engine/score.c      21 Feb 2002 01:06:56 -0000
@@ -205,13 +205,13 @@
          
          if (bubbles[ii] == BLACK
              || (ON_BOARD(SOUTH(ii))
-                 && (gb[SOUTH(ii)] > 0 || bubbles[SOUTH(ii)] == BLACK))
+                 && (gb[SOUTH(ii)] < 0 || bubbles[SOUTH(ii)] == BLACK))
              || (ON_BOARD(WEST(ii))
-                 && (gb[WEST(ii)] > 0 || bubbles[WEST(ii)] == BLACK))
+                 && (gb[WEST(ii)] < 0 || bubbles[WEST(ii)] == BLACK))
              || (ON_BOARD(NORTH(ii))
-                 && (gb[NORTH(ii)] > 0 || bubbles[NORTH(ii)] == BLACK))
+                 && (gb[NORTH(ii)] < 0 || bubbles[NORTH(ii)] == BLACK))
              || (ON_BOARD(EAST(ii))
-                 && (gb[EAST(ii)] > 0 || bubbles[EAST(ii)] == BLACK)))
+                 && (gb[EAST(ii)] < 0 || bubbles[EAST(ii)] == BLACK)))
            black_neighbor = 1;
          
          if (white_neighbor) {