[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gnugo-devel] important bugfix
From: |
Gunnar Farneback |
Subject: |
Re: [gnugo-devel] important bugfix |
Date: |
Sun, 31 Mar 2002 01:29:49 +0100 |
User-agent: |
EMH/1.14.1 SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.3 Emacs/20.7 (sparc-sun-solaris2.7) (with unibyte mode) |
Dan wrote:
> I took down the asserts in this patch. They're triggered by
> in nngs1:tst by the pattern EJ92:
>
> [...]
>
> In the example, h is actually occupied, but the pattern isn't wrong.
> At least, it's written as intended.
It looks okay.
> So I replaced the asserts by
>
> if (board[from] != EMPTY
> || board[to] != EMPTY)
> return;
Keep the assertion of board[to] == EMPTY. It's definitely a serious
bug if a pattern makes a replacement to an occupied vertex. We
shouldn't fail silently in that case.
/Gunnar