Re: Symmetry corrections (was: RE: [gnugo-devel] code maintenance pat ch)

[Gunnar Farneback]

I wrote:
> > I am pointing this out because I think I should change that. (I just
> > looked at the function again and realized _how bad_ the algorithm is
> > in this respect.) It is annoying when adding a new pattern to have to
> > filter out the real change in owl results from this random noise. Changing
> > this function a little could at least reduce the noise.
> 
> Something like this (untested) patch?

It's frightening how large regression delta this patch causes,
presumably all of it accidental. In total 12 passes and 16 failures.

./regress.sh . owl.tst 
23 unexpected PASS!
208 unexpected PASS!
./regress.sh . owl_rot.tst 
70 unexpected FAIL: Correct '1 (J2|K2|N2)', got '0'
./regress.sh . nngs1.tst
8 unexpected PASS!
30 unexpected FAIL: Correct 'P17|O18', got 'N18'
./regress.sh . strategy.tst 
20 unexpected PASS!
29 unexpected PASS!
./regress.sh . neurogo.tst 
20 unexpected FAIL: Correct '1 S16', got '1 T18'
./regress.sh . lazarus.tst
6 unexpected PASS!
15 unexpected PASS!
./regress.sh . trevorb.tst
590 unexpected FAIL: Correct 'H12|M9', got 'E9'
660 unexpected FAIL: Correct 'D3', got 'H5'
./regress.sh . nicklas4.tst
805 unexpected FAIL: Correct 'C5|B4', got 'K7'
./regress.sh . nicklas5.tst
1212 unexpected PASS!
./regress.sh . nngs.tst
120 unexpected PASS!
710 unexpected PASS!
1320 unexpected FAIL: Correct 'O18', got 'R6'
./regress.sh . trevorc.tst
1080 unexpected PASS!
1250 unexpected FAIL: Correct '!C2', got 'C2'
./regress.sh . global.tst
9 unexpected FAIL: Correct 'F4', got 'F2'
14 unexpected FAIL: Correct 'S9', got 'E1'
./regress.sh . arend.tst
4 unexpected FAIL: Correct 'R14|S15|R17', got 'S16'
./regress.sh . 13x13.tst
50 unexpected FAIL: Correct '!N11|M10', got 'N11'
./regress.sh . trevord.tst
120 unexpected FAIL: Correct 'B9', got 'F7'
./regress.sh . strategy4.tst
200 unexpected FAIL: Correct 'P6|P7|Q7|S18', got 'Q8'
./regress.sh . nngs2.tst
240 unexpected FAIL: Correct 'F17', got 'F9'
./regress.sh . nngs3.tst 
460 unexpected FAIL: Correct 'N17|M17|Q17|Q18', got 'H16'
./regress.sh . century2002.tst
130 unexpected FAIL: Correct 'N4', got 'P9'
220 fail
./regress.sh . safety.tst 
5 unexpected PASS!

/Gunnar