Re: [gnugo-devel] twogtp patch

[Evan Berggren Daniel]

On Sat, 26 Oct 2002, Arend Bayer wrote:

>
>
> On Sat, 26 Oct 2002, Evan Berggren Daniel wrote:
>
> > -if ($handicap > 1) {
> > -    $komi = 0.5;
> > +if (!defined $komi) {
> > +    if ($handicap > 1) {
> > +        $komi = 0.5;
> > +    } else {
> > +        $komi = 5.5;
> > +    }
> Shouldn't that be if ($handicap >= 1)? Handicap 1 should be interpreted as
> a no komi game I suppose.
> (That's not the fault of your patch, of course.)

The attached patch fixes that.  Now handicap 1 is defined as 0 stones, 0.5
komi.  Higher handicaps default to 0.5 komi and h0 to 5.5 komi.  The patch
makes this the behavior for twogtp, twogtp-a, and matcher_check.  I have
not checked twogtp.py.

Thanks

Evan Daniel

Index: interface/gtp_examples/matcher_check
===================================================================
RCS file: /cvsroot/gnugo/gnugo/interface/gtp_examples/matcher_check,v
retrieving revision 1.19
diff -u -r1.19 matcher_check
--- interface/gtp_examples/matcher_check        1 Oct 2002 04:39:59 -0000       
1.19
+++ interface/gtp_examples/matcher_check        27 Oct 2002 17:42:12 -0000
@@ -229,6 +229,15 @@
     #set autoflushing for sgf file
     SGFFILEHANDLE->autoflush(1);

+    if (!defined $komi) {
+        if ($handicap > 0) {
+           $komi = 0.5;
+       }
+       else {
+           $komi = 5.5;
+       }
+    }
+
     print $prog_in  "boardsize $size\n";
     eat_no_response($prog_out);
     print $prog_in  "komi $komi\n";
Index: interface/gtp_examples/twogtp
===================================================================
RCS file: /cvsroot/gnugo/gnugo/interface/gtp_examples/twogtp,v
retrieving revision 1.7
diff -u -r1.7 twogtp
--- interface/gtp_examples/twogtp       26 Oct 2002 16:24:57 -0000      1.7
+++ interface/gtp_examples/twogtp       27 Oct 2002 17:42:12 -0000
@@ -434,7 +434,7 @@
 my $black;
 my $size = 19;
 my $games = 1;
-my $komi = 5.5;
+my $komi;
 my $handicap = 0;
 my $sgffile = "twogtp.sgf";

@@ -470,8 +470,13 @@
 ";

 die $helpstring unless defined $white and defined $black;
-if ($handicap > 1) {
-    $komi = 0.5;
+
+if (!defined $komi) {
+    if ($handicap > 0) {
+        $komi = 0.5;
+    } else {
+        $komi = 5.5;
+    }
 }

 # create GTP players
Index: interface/gtp_examples/twogtp-a
===================================================================
RCS file: /cvsroot/gnugo/gnugo/interface/gtp_examples/twogtp-a,v
retrieving revision 1.9
diff -u -r1.9 twogtp-a
--- interface/gtp_examples/twogtp-a     3 Sep 2002 14:19:39 -0000       1.9
+++ interface/gtp_examples/twogtp-a     27 Oct 2002 17:42:12 -0000
@@ -81,7 +81,7 @@
 my $black;
 my $size = 19;
 my $verbose = 0;
-my $komi = 5.5;
+my $komi;
 my $handicap = 0;
 my $games = 1;
 my $wanthelp;
@@ -155,6 +155,15 @@
        undef($sgffilename);
     }

+    if (!defined $komi) {
+        if ($handicap eq 0) {
+           $komi = 5.5;
+       }
+       else {
+           $komi = 0.5;
+       }
+    }
+
     print $black_in  "boardsize $size\n";
     eat_no_response($black_out);
     print $black_in  "komi $komi\n";