[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [gnugo-devel] vcrepair_3_13.1
From: |
bump |
Subject: |
Re: [gnugo-devel] vcrepair_3_13.1 |
Date: |
Tue, 3 Dec 2002 20:08:22 -0800 |
> http://www.public32.com/games/go/vcrepair_3_13.1
> - adds include paths and build dependencies to VC for mkeyes
>
> This obvious patch yields compiler warnings.
> I suppose this patch is correct and the warnings should be fixed.
> [probably just a #undef of DEBUG before the redefine in mkeyes.c(42),
> though this overloading of DEBUG is probably not be ideal. ]
> The gcc definition of DEBUG is typically variadic, and gcc may not
> mind the overloading it (?).
There seems to be no reason for the definition of DEBUG in
mkeyes. This is a standalone program and DEBUG isn't called from
it. It's been in the CVS since the very beginning and probably
has some historical reason.
I checked in Trevor's patch and removed this redefinition of
DEBUG.
Dan