Hilmar Berger wrote:
Today something happened that never should have.
Large pieces of code were moved into the main trunk without informing the
project admins and/or this list.
The worst thing with these changes were that it did not just add code but
change existing code, thereby reverting meaningful patches that had done
before.
"Reverting meaningful patches"? When did these commits take place?
Can't you checkout the latest version before the badness started
occuring, and the commit them? Or maybe I'm underestimating the number
of files which were changed. I haven't looked through the logs so I
don't know. And I'm curious, how did the patches get "reverterd". Did
the user commit without running cvs update first?
I feel that most of the rules makes sense - except those suggesting that we
should have a peer review process.
The reason I don't believe that this well help is that a) there are not
enough developers/reviewers available and b)
the codebase is not at all stable, so that we would have to review a large
number of patches. IMHO this review happens already: I for my part always look
at the changes others made to my code and to code that might be important
for the parts I coded. I believe that others do the same (Karsten usually
cleaned up and fixed the changes I did in his code, I hope he wasn't t
too embarassed that I changed it without previous review).
IMO the most important rule is that you have to think before commiting.
Code, test, retest, make sure you did not introduce new bugs, if unsure contact
the author of that code or admininistator.
I think these are some very good points. Peer review of every piece of
new code is probably not possible with such a small number of
developers. And in other projects I have been involved with before, I
do the same thing you describe, review changes others have made to my
code...
I having written any code for gnumed yet...just hanging around on the
mailing list, I hope to get involved eventually...
--
David J. Grant
Masters Candidate
a-Si and Integrated Circuits Lab
University of Waterloo
Room DC2551A
519-888-4567 x2327
http://www.eng.uwaterloo.ca/~djgrant
|