Re: [Gnumed-devel] Issues with 0.5 detected when trying to package

[Karsten Hilbert]

> 1. gnumed-client.conf.example:
> 
> ...
> [profile public GNUmed database]
> host = salaam.homeunix.com
> port = 5432
> database = gnumed_v10
>                   ^^^
> 
> Shouldn't this be v11?

It should but the file is only an example. It is usually helpful
to be able to think.

> 2. external-tools
> 
>    Karsten asked me to install /usr/bin/gm-install_arriba
>    I will refuse to do so in the current state because this script
>    is doing "dirty" things.
> 
>    1. INSTALL_BASE="/usr/bin" - no, I will *not* provide a script
>       which moves any file not under control of the package manager
>       to /usr/bin.  I can't avoid that admins do such things, but I
>       will not tell them to do so.
>       --> I would generally advise to use
>         INSTALL_BASE="/usr/local/bin"

That's true. Will fix that.

>    2. The script would also require Java (well, not your installer
>       script, but the jar you are installing.  So what is the sense
>       to install a piece of software without ensuring that it will
>       work.  This could be done with an extra Recommends / Suggests
>       openjdk-6-jre (if the jar works with this).  But I would really
>       hesitate to bloat gnumed-client dependencies to much.

Only gnumed-client-de. Make it Suggests.

>    3. Guessing from the name the script is intended to be called
>       only once (to install a piece of software.  IMHO the solution
>       of choice (even if the two items above would not be valid)
>       would be to move this to /usr/share/doc/examples or something
>       like this.

Well, that's up to you as packager. But then you'll break one
functionality of GNUmed (well, not sure, can't check right now,
it might work as well since it may call it with the PATH, not directly).


>       Executables in /usr/bin need a valid man page
>       as documentation - well I really think this script deserves
>       documentation anyway - and you obviosely have refused to
>       write such anyway.

No one asked so I can't have refused. Anyway, better move to
/usr/local/bin/ then   :-)

>   The other two downloaders: Please explain the sense of moving
>   data to /tmp rather than to /var/lib/gnumed/(tmp).  The
>   directory /tmp is removed after each boot process.  So what is
>   the sense of these data and how are the scripts used?

They are called from within GNUmed to download updates of the LOINC
and ATC reference data sets. After they are downloaded they get
imported into the database. No problem if they are deleted at the
next cleaning of /tmp. In fact, we *want* that :-)

Karsten
-- 
Jetzt kostenlos herunterladen: Internet Explorer 8 und Mozilla Firefox 3 -
sicherer, schneller und einfacher! http://portal.gmx.net/de/go/atbrowser