gnumed-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Gnumed-devel] Some country names now accented - problem with generi


From: Rogerio Luz Coelho
Subject: Re: [Gnumed-devel] Some country names now accented - problem with generic
Date: Fri, 9 Dec 2011 21:00:46 -0200



2011/12/1 Karsten Hilbert <address@hidden>
On Wed, Nov 30, 2011 at 04:53:16PM +0000, Jim Busser wrote:

> > Unfortunately it means that I missed to consider this point
> > and that the generic translation target introduces an
> > undesired side-effect.
> >
> > Point in case why minor version changes should be kept
> > extremely limited and best restricted to actual bug fixes.
> > I've been fairly liberal with applying changes to 1.1 and
> > that's what we get from doing so.
>
> So far I would not consider the above any problem, it is making a better GNUmed …

Only partially so and it uses a wrong approach.

> > As it stands the generic translation target (and hence a
> > data pack for it) should only be applied if *really* needed.
> >
> > I'll disable the "generic" target again - I've always said
> > this approach is a crutch at best - and it shows.
>
> Mainly it underscores the need for users and their IT
> support to think through a feature before they decide to use
> it.

While true the feature should not be broken by design. I now
consider the "generic" approach borked-by-design because it
will not allow isolation - id est one cannot have one user
*wanting* the accented strings while another one not wanting
them within the same GNUmed backend (a band aid of the
problem would be to make it configurable but that's more
work than I currently care for given a) the marginal benefit
and b) the existence of a proper approach, and also quite
fragile).

> This side effect is completely reversible by removing
> the generic translations

Yes.

> since it is the orig and not translational string that is
> relied upon to maintain data integrity.

No. Data integrity is maintained by integer foreign keys,
not by strings.

> Had I taken more time to inspect the Portuguese data
> source, it would have occurred to me that not all users
> would wish to be shown accented versions and so it would
> have made more sense for me to have scripted those accented
> place names to be inserted with lang 'pt' not lang 'generic'
> and we can concede what I was scripting did not yet even
> make it to the state of released data pack. :-)

That's why I swiftly disabled "generic" again.

Karsten


 :) Brazilians will rule the world :)

R.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]