Re: [Gnump3d-users] Re: Single quotes and $new_days

[Steve Kemp]

On Mon, May 23, 2005 at 09:43:40AM +0300, Matti Somppi wrote:
> On 5/7/05, Matti Somppi <address@hidden> wrote:
> 
> ----clip----
> > I'm not that familiar with Perl (I usually code with C), but I tried
> > to review the code a bit and noticed I get this problem fixed by
> > changing the line 1737 in gnump3d2 to
> > 
> >       $safeFile    = "\"" . $file . "\"";. 
> ----clip----
> > I also noticed that the links in most recent tracks were broken if the
> > file names contained single quotes. I managed to fix this by changing
> > the line 154 in recent.pm to
> > 
> >     $text .= 
> > "<tr><td>$host</td><td><ahref=\"/$2$suffix\">$disp</a></td></tr>\n";
> ----clip----
> 
> Am I writing to a wrong list or has anybody taken a look at this? 

  The latter .. I must have missed it, my apologies.

  I've committed both fixes now.

> Anyway, I found that the $new_days parameter in the /etc/gnump3d.conf
> is not working as it should (changing the value of it has no effect).
> This can be fixed by changing the line 3320 in gnump3d2 from
> 
>       $new_days   = getConfig( "new_count", 7 );
> to
>       $new_days   = getConfig( "new_days", 7 );
> 
> The other way is of course to change the parameter name in
> gnump3d.conf to $new_count.

  Sure, I changed the code rather than the configuration file name.

Steve
--
http://www.steve.org.uk/