[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GNUnet-developers] [patch] doc fixes

From: Christian Grothoff
Subject: Re: [GNUnet-developers] [patch] doc fixes
Date: Wed, 6 May 2009 08:17:00 -0600
User-agent: KMail/1.11.2 (Linux/2.6.27-11-generic; KDE/4.2.2; i686; ; )

On Wednesday 06 May 2009 08:01:21 am David Kuehling wrote:
> Hi,
> attached you find a patch (against head) that fixes the gnunet-search
> manual page and the --help output of gnunet-pseudonym.

Patch applied. Thank you!

> BTW I somewhat dislike the current implementation of keyword parsing in
> gnunet-search: if there is only one argument, the argument is broken at
> spaces, if there is more than one arguments, each argument is taken
> (almost) literally as a keyword.
> $ gnunet-search "Das Kapital"
> searches for ("Das" OR "Kapital")
> while
> $ gnunet-search "Marx" "Das Kapital"
> searches for ("Marx" OR "Das Kapital")

I agree that this is not nice.

> I'd suggest to _not_ change argument treatment based on the number of
> arguments, and never break arguments at spaces.  However, for shell
> scripts etc it might be nice to have an option to specify a single
> keyword string to be broken.  Why not support that via specific option?
> e.g.
> $ gnunet-search --search-string="Das Kapital"
> to search for ("Das" OR "Kapital")
> If you're ok with it, I could submit a patch that implements such a fix
> and updates the man-page once again.

Sounds good to me. 


reply via email to

[Prev in Thread] Current Thread [Next in Thread]