Re: [GNUnet-developers] [PATCH] transport_tcp: make use of GNUNET_HELLO_address_check_option

[Christian Grothoff]

Hi Daniel,

Patch looks good, just makes the code use the more "modern" style, and
does not change anything semantically.

-Christian

On 05/12/2016 03:52 PM, Daniel Golle wrote:
> Spotted this while reviewing HELLO and its users.
> I guess this this was probably forgotten earlier, however, I hestitate
> to commit it, so please have a look at my suggestion:
> ---
>  src/transport/plugin_transport_tcp.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/src/transport/plugin_transport_tcp.c 
> b/src/transport/plugin_transport_tcp.c
> index b1c68ac..2d92b25 100644
> --- a/src/transport/plugin_transport_tcp.c
> +++ b/src/transport/plugin_transport_tcp.c
> @@ -545,9 +545,8 @@ notify_session_monitor (struct Plugin *plugin,
>      return;
>    memset (&info, 0, sizeof (info));
>    info.state = state;
> -  info.is_inbound = (0 != (GNUNET_HELLO_ADDRESS_INFO_INBOUND & 
> session->address->local_info))
> -    ? GNUNET_YES
> -    : GNUNET_NO;
> +  info.is_inbound = GNUNET_HELLO_address_check_option (session->address,
> +                                         GNUNET_HELLO_ADDRESS_INFO_INBOUND)
>    info.num_msg_pending = session->msgs_in_queue;
>    info.num_bytes_pending = session->bytes_in_queue;
>    if (NULL != session->receive_delay_task)
>

signature.asc
Description: OpenPGP digital signature