Re: [GNUnet-developers] [PATCH 0/4] Fix tests

[Daniel Golle]

Hi,

thank you for your contribution!

On Sun, Jun 25, 2017 at 12:47:46PM +0100, jah wrote:
> Hi List,
> 
> Some fixes for tests:- 
> 
> The first patch fixes a segfault in each of the test_transport_blacklisting_*
> tests by providing a PeerContext closure, representing the started peer, to 
> the
> peer start callback.  These segfaults surfaced very recently, possibly as a
> result of fixing blacklisting.
> 
> The second corrects an indexing error to fix [#4907].
> 
> Third is a minor formatting improvement.
> 
> Fourth reverts 79dc9cac which erroneously changed the relative path to an
> included conf file - GNUNET_STRINGS_filename_expand resolves relative paths
> relative to getcwd (i.e. the dir into which make check descends).
> 
> [#4907]: https://gnunet.org/bugs/view.php?id=4907

As said, this should rather be addressed in a way which makes the
path relative to the directory the file is stored in.

As a sidenote, it'd be great if you PGP-sign future patches.
In this case, as they were all rather small, I've signed them for you
to get them committed.


> 
> jah (4):
>   Ensure peer started callback recvs PeerContext
>   Fix quota compliance tests.
>   Fix debug message.
>   Fix relative path in included conf
> 
>  src/cadet/cadet_api.c                          | 2 +-
>  src/integration-tests/confs/test_defaults.conf | 4 ++--
>  src/transport/test_quota_compliance.c          | 8 ++++----
>  src/transport/transport-testing.c              | 5 ++++-
>  4 files changed, 11 insertions(+), 8 deletions(-)
> 
> -- 
> 2.13.1
> 
> 
> _______________________________________________
> GNUnet-developers mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/gnunet-developers