gnunet-developers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GNUnet-developers] libextractor: meta-type for narinfo?


From: ng0
Subject: Re: [GNUnet-developers] libextractor: meta-type for narinfo?
Date: Thu, 14 Sep 2017 15:08:18 +0000

ng0 transcribed 3.2K bytes:
> Christian Grothoff transcribed 29K bytes:
> > On 09/14/2017 02:41 PM, ng0 wrote:
> > > Hi Christian and LRN.
> > > 
> > > I'm going through `gnunet-guile` at the moment
> > > to understand and improve it.
> > > I just found this comment in it (with context):
> > > 
> > > ```
> > > (define metadata-type-alist
> > >   '((#:filename          .   2)
> > >     (#:publication-date  .  24)
> > >     (#:unknown           .  45)
> > >     (#:original-filename . 180)
> > >     ;; temporary until the right meta-type is added to libextractor
> > >     (#:narinfo           . 230)))
> > > 
> > > ```
> > > 
> > > Read gnu/gnunet/container/metadata.scm in 'gnunet-guile'
> > > on our git server if you need more context.
> > > 
> > > This is work mainly from GSoC 2015.
> > > Has a meta-type (?) for narinfo been added to
> > > libextractor since then?
> > > If not, what's needed to get it in?
> > 
> > Well, it's an enum value, so first a trivial patch to extractor.h, plus
> > a human-readable textual description in src/main/extractor_metatypes.c
> > of what "narinfo" is about.
> 
> Okay, thanks.
> I'll see what I can come up with as soon as I can
> work on it.
> 
> > I'm confused by the choice of 230, the next
> > free value is 229, and we should not leave holes.  So unless
> > compatibility is an issue, the value should probably be changed to 229.
> 
> As far as I could see, and given that this application
> (gnunet-guile) is currently not in use anywhere there's
> no compability to consider. I changed it to 229.

I was able to work on it already.

I hope there's a specification somewhere (if you need it),
the only references are Nix and Guix.
https://www.gnu.org/software/guix/manual/html_node/Invoking-guix-archive.html#Invoking-guix-archive

I've attached my addition of nar and narinfo, haven't run a build
with it but it shouldn't break anything.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://krosos.org/dist/keys/
https://www.infotropique.org https://www.krosos.org

Attachment: 0001-Add-nar-and-narinfo.patch
Description: Text document

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]