Re: [GNUnet-developers] Please review: C implementation of gnunet-qr

[ng0]

Hi,

Hartmut Goebel transcribed 656 bytes:
> Hi,
> 
> I just pushed the branch "gnunt-qt-c".
> 
> Please review and give feedback. And somebody is asked to implement
> c-style error handling (or guide me): The "processor" must be cleaned up
> at the end, even if an error occurred. How is this done in C?
> 
> Please do not merge yet! IMHO error handling should be done first.

Minor criticsm, which can be fixed once it is merged (because I think
almost everyone of us will have pkgconf or pkg-config installed):

We do not want to rely on pkg-config / pkgconf, as you can see
in the rest of the configure.ac. You don't have to fix this if
you don't want to, someone else can do it.

I can't comment on the rest.

Thanks

> Regards
> Hartmut Goebel
> 
> | Hartmut Goebel          | address@hidden               |
> | www.crazy-compilers.com | compilers which you thought are impossible |
> 
> 
> _______________________________________________
> GNUnet-developers mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/gnunet-developers
>