gnunet-developers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GNUnet-developers] Coding style clang-format


From: Schanzenbach, Martin
Subject: Re: [GNUnet-developers] Coding style clang-format
Date: Tue, 16 Apr 2019 11:32:44 +0200

Updated the format file with all your propsals. Now needs a clang-format which 
at least includes this commit: 
https://github.com/llvm-mirror/clang/commit/c4515d09740be87226d185f7728893d26c5af652

i.e. > clang 8.0.0; let's hope they release soon (tm)

> On 16. Apr 2019, at 11:17, Schanzenbach, Martin <address@hidden> wrote:
> 
> Signed PGP part
> 
> 
>> On 16. Apr 2019, at 10:54, Christian Grothoff <address@hidden> wrote:
>> 
>> Signed PGP part
>> On 4/16/19 10:48 AM, Schanzenbach, Martin wrote:
>>> I added your changes with two notes:
>>> 
>>> 1. SpaceAfterLogicalNot: true => This option does not seems to exist 
>>> (anymore?)
>> 
>> That's a pity. I think this is a nice way to emphasize the not.
> 
> I checked. It has been added recently. You need clang-format > 8.0.0 (i.e. 
> currently git HEAD)
> 
>> 
>>> 2. AllowAllParametersOfDeclarationOnNextLine: false # CG: documentation has 
>>> AllowAllArgumentsOfDeclarationsOnNextLine! => I don't know what you mean by 
>>> this.
>> 
>> It means that the Web manual I was reading had an option with
>> "Arguments" in the name, while your file had "Parameters", so I don't
>> know what it should be, or whether the docs I'm reading matched what the
>> option does.
> 
> Ah. Probably a typo in the docs.
> 
>> 
>> 
>> 
> 
> 
> 

Attachment: signature.asc
Description: Message signed with OpenPGP


reply via email to

[Prev in Thread] Current Thread [Next in Thread]