gnunet-developers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gnunet mysql errors


From: Christian Grothoff
Subject: Re: gnunet mysql errors
Date: Wed, 1 Feb 2023 08:57:26 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0

Well, I touched it because it didn't build on my system(s), and with my fix it did. But of course, I didn't test all the various mysql versions...

Maybe we should introduce a configure-level check for 'my_bool' instead of relying on the MySQL version? Just reverting the code is sure to then simply cause a similar FTBFS on one of my systems.

On 2/1/23 01:19, Martin Schanzenbach wrote:

This is a regression introduced by Christian recently:
https://git.gnunet.org/gnunet.git/commit/?id=b73a7c5da48e09bd39c1d7c1dabec269dbacd1c8

I think the check before this commit was correct (and the comment
wrong).

Br
Martin

Nikita Ronja Gillmann <nikita@NetBSD.org> writes:

mysql is correctly detected (version: mysql-client-8.0.31nb1).

yet I run into this. any idea if this is on your side or mine?

gmake[3]: Entering directory '/usr/work/net/gnunet/work/gnunet-0.19.2/src/mysql'
    CC       mysql.lo
In file included from mysql.c:28:
mysql.c: In function 'iopen':
../../src/include/gnunet_mysql_compat.h:48:20: error: 'my_bool' undeclared 
(first use in this function); did you mean 'bool'?
     48 | #define MYSQL_BOOL my_bool; //MySQL < 8 wants this
        |                    ^~~~~~~
mysql.c:224:3: note: in expansion of macro 'MYSQL_BOOL'
    224 |   MYSQL_BOOL reconnect;
        |   ^~~~~~~~~~
../../src/include/gnunet_mysql_compat.h:48:20: note: each undeclared identifier 
is reported only once for each function it appears in
     48 | #define MYSQL_BOOL my_bool; //MySQL < 8 wants this
        |                    ^~~~~~~
mysql.c:224:3: note: in expansion of macro 'MYSQL_BOOL'
    224 |   MYSQL_BOOL reconnect;
        |   ^~~~~~~~~~
mysql.c:224:14: error: 'reconnect' undeclared (first use in this function); did 
you mean 'connect'?
    224 |   MYSQL_BOOL reconnect;
        |              ^~~~~~~~~
        |              connect
gmake[3]: *** [Makefile:560: mysql.lo] Error 1
gmake[3]: Leaving directory '/usr/work/net/gnunet/work/gnunet-0.19.2/src/mysql'
gmake[2]: *** [Makefile:548: all-recursive] Error 1
gmake[2]: Leaving directory '/usr/work/net/gnunet/work/gnunet-0.19.2/src'
gmake[1]: *** [Makefile:599: all-recursive] Error 1
gmake[1]: Leaving directory '/usr/work/net/gnunet/work/gnunet-0.19.2'
gmake: *** [Makefile:510: all] Error 2
*** Error code 2

Stop.
make[1]: stopped in /usr/pkgsrc/net/gnunet
*** Error code 1



reply via email to

[Prev in Thread] Current Thread [Next in Thread]