[GNUnet-SVN] r3113 - branches/GNUnet-0.7.0/src/server

[grothoff]

Author: grothoff
Date: 2006-07-09 13:14:23 -0700 (Sun, 09 Jul 2006)
New Revision: 3113

Modified:
   branches/GNUnet-0.7.0/src/server/connection.c
Log:
From: 
Heikki Lindholm <address@hidden>
  To: 
  Christian Grothoff <address@hidden>
    Date: 
    Today 09:06:38 am
       
         Spam Status: Spamassassin 0% probability of being spam.

         Full report:
         No, score=-2.0 required=5.0 tests=BAYES_00, MSGID_FROM_MTA_HEADER 
autolearn=ham version=3.1.3  Bogofilter 0% probability of being spam.

         Full report:
         Ham, tests=bogofilter, spamicity=0.000000, version=1.0.2  
         Hi,

         I'm trying to run GNUnet 0.7.0e on a SPARC linux box (Ubuntu.) It 
always 
         crashes after running a few minutes at most. The crash happens always 
at 
         the same spot, which makes little sense to me:
         Program received signal SIGBUS, Bus error.
         [Switching to Thread -199525456 (LWP 24146)]
         sendBuffer (be=0xa1b40) at connection.c:1384
         1384        part->size = htons(noiseLen);
         (gdb) bt
         #0  sendBuffer (be=0xa1b40) at connection.c:1384
         #1  0xf7ecb654 in cronDecreaseLiveness (unused=<value optimized out>)
              at connection.c:2205
              #2  0xf7ee2b6c in cron (unused=<value optimized out>) at 
cron.c:535
              #3  0xf7dd9c54 in start_thread () from /lib/libpthread.so.0
              #4  0xf7d57c98 in clone () from /lib/libc.so.6
              (gdb) bt full
              #0  sendBuffer (be=0xa1b40) at connection.c:1384
                       part = (P2P_MESSAGE_HEADER *) 0x198a5f
                                noiseLen = <value optimized out>
                                         i = <value optimized out>
                                                  j = <value optimized out>
                                                           p = 1359
                                                                    rsi = 
<value optimized out>
                                                                             
pos = (SendCallbackList *) 0x0
                                                                                
      priority = 16777215
                                                                                
               perm = (int *) 0x17cef8
                                                                                
                        plaintextMsg = 0x198510 ""
                                                                                
                                 encryptedMsg = <value optimized out>
                                                                                
                                          totalMessageSize = 1404
                                                                                
                                                   ret = <value optimized out>
                                                                                
                                                   #1  0xf7ecb654 in 
cronDecreaseLiveness (unused=<value optimized out>)
                                                                                
                                                        at connection.c:2205
                                                                                
                                                                 root = <value 
optimized out>
                                                                                
                                                                          prev 
= (BufferEntry *) 0x0
                                                                                
                                                                                
   now = 1152458261452
                                                                                
                                                                                
            i = 10
                                                                                
                                                                                
            #2  0xf7ee2b6c in cron (unused=<value optimized out>) at cron.c:535
                                                                                
                                                                                
                     now = 1152458261452
                                                                                
                                                                                
                              next = <value optimized out>
                                                                                
                                                                                
                              #3  0xf7dd9c54 in start_thread () from 
/lib/libpthread.so.0
                                                                                
                                                                                
                              No symbol table info available.
                                                                                
                                                                                
                              #4  0xf7d57c98 in clone () from /lib/libc.so.6
                                                                                
                                                                                
                              No symbol table info available.

                                                                                
                                                                                
                              Adding printf's around the htons line made the 
crash move forward in 
                                                                                
                                                                                
                              sendBuffer. The difficulty is that I also tested 
GNUnet briefly on a 
                                                                                
                                                                                
                              powerpc ubuntu box and there it seemed to run 
just fine. I also tried 
                                                                                
                                                                                
                              compiling with gcc-3.4 instead of the default 
gcc-4.0. So, I'm quite 
                                                                                
                                                                                
                              clueless. Anyway, are there people running GNUnet 
on big endian boxes?



Modified: branches/GNUnet-0.7.0/src/server/connection.c
===================================================================
--- branches/GNUnet-0.7.0/src/server/connection.c       2006-07-09 20:12:50 UTC 
(rev 3112)
+++ branches/GNUnet-0.7.0/src/server/connection.c       2006-07-09 20:14:23 UTC 
(rev 3113)
@@ -1381,12 +1381,14 @@
   /* finally padd with noise */
   if ( (p + sizeof(P2P_MESSAGE_HEADER) <= totalMessageSize) &&
        (disable_random_padding == NO) ) {
-    P2P_MESSAGE_HEADER *part;
+    P2P_MESSAGE_HEADER part;
     unsigned short noiseLen = totalMessageSize - p;
 
-    part = (P2P_MESSAGE_HEADER *) & plaintextMsg[p];
-    part->size = htons(noiseLen);
-    part->type = htons(P2P_PROTO_noise);
+    part.size = htons(noiseLen);
+    part.type = htons(P2P_PROTO_noise);
+    memcpy(&plaintextMsg[p], 
+           &part,
+          sizeof(P2P_MESSAGE_HEADER));
     for (i = p + sizeof(P2P_MESSAGE_HEADER); i < totalMessageSize; i++)
       plaintextMsg[i] = (char) rand();
     p = totalMessageSize;