[GNUnet-SVN] r19602 - gnunet-gtk/src/fs

[gnunet]

Author: grothoff
Date: 2012-02-01 18:07:27 +0100 (Wed, 01 Feb 2012)
New Revision: 19602

Modified:
   gnunet-gtk/src/fs/gnunet-fs-gtk-event_handler.c
Log:
-characterizing FIXMEs

Modified: gnunet-gtk/src/fs/gnunet-fs-gtk-event_handler.c
===================================================================
--- gnunet-gtk/src/fs/gnunet-fs-gtk-event_handler.c     2012-02-01 16:35:15 UTC 
(rev 19601)
+++ gnunet-gtk/src/fs/gnunet-fs-gtk-event_handler.c     2012-02-01 17:07:27 UTC 
(rev 19602)
@@ -143,13 +143,13 @@
 
 /**
  * Row reference for the current search context menu.
- * FIXME: de-globalize?
+ * FIXME-UNCLEAN: de-globalize?
  */
 static GtkTreeRowReference *current_context_row_reference;
 
 /**
  * Search tab used for the current search context menu.
- * FIXME: de-globalize?
+ * FIXME-UNCLEAN: de-globalize?
  */
 static struct SearchTab *current_context_search_tab;
 
@@ -171,7 +171,7 @@
 static char *
 get_default_download_directory (char *buffer, size_t size)
 {
-  /* FIXME: implement... */
+  /* FIXME-FEATURE: implement... */
   return NULL;
 }
 
@@ -212,7 +212,7 @@
   const char *basename; 
   char *dot;
 
-  /* FIXME: this function is likely responsible for not always
+  /* FIXME-BUG-MAYBE: this function is likely responsible for not always
      suggesting the best filename... To be investigated some more... */
   gtk_tree_model_get (tm, iter, 0, &meta, 
                      15, &local_filename, 
@@ -609,7 +609,7 @@
              sr,
              sr->download);
 
-  /* FIXME: move these to some menu context struct
+  /* FIXME-UNCLEAN: move these to some menu context struct
      (de-globalize) */
   current_context_search_tab = tab;
   if (current_context_row_reference != NULL)
@@ -1033,7 +1033,7 @@
   tm = GTK_TREE_MODEL (tab->ts);
   if (TRUE != gtk_tree_model_get_iter_first (tm, &iter))
     return;
-  /* FIXME: this is a tree, what about cleaning up
+  /* FIXME-BUG: this is a tree, what about cleaning up
      of the children? */
   do
   {
@@ -1257,7 +1257,7 @@
     /* opened directory file */
     fsize = 0;
     status_colour = "gray";
-    mime = NULL; /* FIXME: should we set mime to directory? */
+    mime = NULL; /* FIXME-FEATURE-MAYBE: should we set mime to directory? */
     uris = GNUNET_strdup (_("no URI"));
   }
   else
@@ -1271,8 +1271,8 @@
     }
     else
     {
-      /* FIXME: create mime type for namespaces? */
-      /* FIXME: can we encounter ksk URIs here too? */
+      /* FIXME-FEATURE-MAYBE: create mime type for namespaces? */
+      /* FIXME-BUG-MAYBE: can we encounter ksk URIs here too? */
       fsize = 0;
       mime = GNUNET_strdup ("GNUnet namespace"); 
       status_colour = "lightgreen";
@@ -1448,7 +1448,7 @@
       GTK_LABEL (gtk_builder_get_object
                  (tab->builder, "_search_result_label_window_label"));
 
-  /* FIXME: connect these signals using glade!!! */
+  /* FIXME-UNCLEAN: connect these signals using glade!!! */
   tab->close_button =
       GTK_WIDGET (gtk_builder_get_object
                   (tab->builder, "_search_result_label_close_button"));
@@ -1472,7 +1472,7 @@
   /* patch text */
   update_search_label (tab);
 
-  /* add signal handlers; FIXME: again, connect these with glade...  */
+  /* add signal handlers; FIXME-UNCLEAN: again, connect these with glade...  */
   tv = GTK_TREE_VIEW (gtk_builder_get_object
                       (tab->builder, "_search_result_frame"));
   g_signal_connect (G_OBJECT (tv), "row-activated", 
@@ -1511,7 +1511,7 @@
  * find it when we get this kind of 'inner' search results (so that we
  * can then place them in the tree view in the right spot).
  *
- * FIXME: don't we need a bit more information then? Like exactly where
+ * FIXME-BUG-MAYBE: don't we need a bit more information then? Like exactly 
where
  * this 'right spot' is?  Not sure how just having 'sc' helps there,
  * as it is not a search result (!) to hang this up on!  This might
  * essentially boil down to an issue with the FS API, not sure...
@@ -1723,7 +1723,7 @@
   if (NULL == uri)
   {
     /* directory meta data itself */
-    /* FIXME: consider merging it with the meta data from
+    /* FIXME-FEATURE-MAYBE: consider merging it with the meta data from
        the original search result... */
     return;
   }
@@ -1788,7 +1788,7 @@
     return;
   }
   gtk_tree_path_free (path);
-  /* FIXME: update availability-score here as well! */
+  /* FIXME-FEATURE: update availability-score here as well! */
   gtk_tree_store_set (de->ts, &iter, 
                      4, (guint) ((size >
                                   0) ? (100 * completed /
@@ -2376,7 +2376,7 @@
     gtk_container_remove (GTK_CONTAINER (df), tab_label);
     gtk_widget_destroy (GTK_WIDGET (df));
     
-    /* FIXME: connect these signals using GLADE!!! */
+    /* FIXME-UNCLEAN: connect these signals using GLADE!!! */
     /* get refs to widgets */
     close_button =
       GTK_WIDGET (gtk_builder_get_object