[GNUnet-SVN] r23978 - in gnunet/src: gns util

[gnunet]

Author: wachs
Date: 2012-09-24 14:39:08 +0200 (Mon, 24 Sep 2012)
New Revision: 23978

Modified:
   gnunet/src/gns/gnunet-service-gns_resolver.c
   gnunet/src/util/os_priority.c
   gnunet/src/util/test_os_start_process.c
Log:
coverity bugs

Modified: gnunet/src/gns/gnunet-service-gns_resolver.c
===================================================================
--- gnunet/src/gns/gnunet-service-gns_resolver.c        2012-09-24 12:25:26 UTC 
(rev 23977)
+++ gnunet/src/gns/gnunet-service-gns_resolver.c        2012-09-24 12:39:08 UTC 
(rev 23978)
@@ -4160,9 +4160,9 @@
     {
       GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                   "Cannot convert ZKEY %s to hash!\n", nzkey);
+      GNUNET_CONTAINER_DLL_remove (nsh_head, nsh_tail, rh);
       GNUNET_free (rh);
       GNUNET_free (nsh);
-      GNUNET_CONTAINER_DLL_remove (nsh_head, nsh_tail, rh);
       proc (proc_cls, name);
       return;
     }

Modified: gnunet/src/util/os_priority.c
===================================================================
--- gnunet/src/util/os_priority.c       2012-09-24 12:25:26 UTC (rev 23977)
+++ gnunet/src/util/os_priority.c       2012-09-24 12:39:08 UTC (rev 23978)
@@ -860,7 +860,10 @@
     return NULL; /* not executable */
   if ( (GNUNET_YES == pipe_control) &&
        (GNUNET_OK != npipe_setup (&childpipename)) )
-    return NULL;  
+  {
+    GNUNET_free (childpipename);
+    return NULL;
+  }
   if (NULL != pipe_stdout)
   {
     GNUNET_assert (GNUNET_OK ==

Modified: gnunet/src/util/test_os_start_process.c
===================================================================
--- gnunet/src/util/test_os_start_process.c     2012-09-24 12:25:26 UTC (rev 
23977)
+++ gnunet/src/util/test_os_start_process.c     2012-09-24 12:39:08 UTC (rev 
23978)
@@ -197,6 +197,7 @@
   hello_pipe_stdout = GNUNET_DISK_pipe (GNUNET_YES, GNUNET_YES, GNUNET_NO, 
GNUNET_YES);
   if ((hello_pipe_stdout == NULL) || (hello_pipe_stdin == NULL))
   {
+    GNUNET_free (fn);
     return 1;
   }
   proc =
@@ -230,6 +231,7 @@
   hello_pipe_stdout = GNUNET_DISK_pipe (GNUNET_YES, GNUNET_YES, GNUNET_NO, 
GNUNET_YES);
   if ((hello_pipe_stdout == NULL) || (hello_pipe_stdin == NULL))
   {
+    GNUNET_free (fn);
     return 1;
   }
   proc =