[GNUnet-SVN] r29301 - in gnunet/src: identity psycstore

[gnunet]

Author: tg
Date: 2013-09-16 14:21:10 +0200 (Mon, 16 Sep 2013)
New Revision: 29301

Modified:
   gnunet/src/identity/gnunet-service-identity.c
   gnunet/src/psycstore/gnunet-service-psycstore.c
   gnunet/src/psycstore/test_psycstore.c
Log:
psycstore: fixing issues reported by static code analysis

Modified: gnunet/src/identity/gnunet-service-identity.c
===================================================================
--- gnunet/src/identity/gnunet-service-identity.c       2013-09-16 12:19:01 UTC 
(rev 29300)
+++ gnunet/src/identity/gnunet-service-identity.c       2013-09-16 12:21:10 UTC 
(rev 29301)
@@ -189,7 +189,8 @@
   rcm->header.type = htons (GNUNET_MESSAGE_TYPE_IDENTITY_RESULT_CODE);
   rcm->header.size = htons (sizeof (struct GNUNET_IDENTITY_ResultCodeMessage) 
+ elen);
   rcm->result_code = htonl (result_code);
-  memcpy (&rcm[1], emsg, elen);
+  if (0 < elen)
+    memcpy (&rcm[1], emsg, elen);
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
              "Sending result %d (%s) to client\n",
              (int) result_code,

Modified: gnunet/src/psycstore/gnunet-service-psycstore.c
===================================================================
--- gnunet/src/psycstore/gnunet-service-psycstore.c     2013-09-16 12:19:01 UTC 
(rev 29300)
+++ gnunet/src/psycstore/gnunet-service-psycstore.c     2013-09-16 12:21:10 UTC 
(rev 29301)
@@ -113,7 +113,8 @@
   res->header.size = htons (sizeof (struct OperationResult) + err_len);
   res->result_code = htonl (result_code);
   res->op_id = op_id;
-  memcpy (&res[1], err_msg, err_len);
+  if (0 < err_len)
+    memcpy (&res[1], err_msg, err_len);
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
              "Sending result %d (%s) to client\n",
              (int) result_code,
@@ -607,6 +608,7 @@
         ret = db->state_get (db->cls, &req->channel_key, n,
                              &send_state_var, &sc);
       }
+      GNUNET_free (n);
     }
   }
   switch (ret)

Modified: gnunet/src/psycstore/test_psycstore.c
===================================================================
--- gnunet/src/psycstore/test_psycstore.c       2013-09-16 12:19:01 UTC (rev 
29300)
+++ gnunet/src/psycstore/test_psycstore.c       2013-09-16 12:21:10 UTC (rev 
29301)
@@ -454,7 +454,8 @@
                              - sizeof (msg->hop_counter)
                              - sizeof (msg->signature));
   msg->purpose.purpose = htonl (234);
-  GNUNET_CRYPTO_ecc_sign (slave_key, &msg->purpose, &msg->signature);
+  ASSERT (GNUNET_OK == GNUNET_CRYPTO_ecc_sign (slave_key, &msg->purpose,
+                                               &msg->signature));
 
   op = GNUNET_PSYCSTORE_fragment_store (h, &channel_pub_key, msg, 
fcls.flags[0],
                                         &fragment_store_result, GNUNET_NO);