gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GNUnet-SVN] r33572 - gnunet-gtk/src/namestore


From: gnunet
Subject: [GNUnet-SVN] r33572 - gnunet-gtk/src/namestore
Date: Fri, 6 Jun 2014 15:36:08 +0200

Author: grothoff
Date: 2014-06-06 15:36:08 +0200 (Fri, 06 Jun 2014)
New Revision: 33572

Modified:
   gnunet-gtk/src/namestore/plugin_gtk_namestore_box.c
   gnunet-gtk/src/namestore/plugin_gtk_namestore_srv.c
Log:
-comment

Modified: gnunet-gtk/src/namestore/plugin_gtk_namestore_box.c
===================================================================
--- gnunet-gtk/src/namestore/plugin_gtk_namestore_box.c 2014-06-06 13:32:30 UTC 
(rev 33571)
+++ gnunet-gtk/src/namestore/plugin_gtk_namestore_box.c 2014-06-06 13:36:08 UTC 
(rev 33572)
@@ -17,11 +17,19 @@
   * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
   * Boston, MA 02111-1307, USA.
   */
-
 /**
  * @file namestore/plugin_gtk_namestore_box.c
  * @brief namestore plugin for editing BOXed records
  * @author Christian Grothoff
+ *
+ * This code is a bit hackish, as we re-use the existing logic for the
+ * boxed type.  This is done by switching on the record type of the
+ * box -- and by including the code of the other plugins in this
+ * code, and the widgets of the other plugins in the XML for the box
+ * plugin.  This is particularly hackish as we then need to make sure
+ * that the names of the shared widgets and callbacks are identical
+ * across the different plugins that are being boxed.  This currently
+ * affects the SRV and TLSA plugins.
  */
 #include "gnunet_gtk.h"
 #include "gnunet_gtk_namestore_plugin.h"

Modified: gnunet-gtk/src/namestore/plugin_gtk_namestore_srv.c
===================================================================
--- gnunet-gtk/src/namestore/plugin_gtk_namestore_srv.c 2014-06-06 13:32:30 UTC 
(rev 33571)
+++ gnunet-gtk/src/namestore/plugin_gtk_namestore_srv.c 2014-06-06 13:36:08 UTC 
(rev 33572)
@@ -17,11 +17,15 @@
   * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
   * Boston, MA 02111-1307, USA.
   */
-
 /**
  * @file namestore/plugin_gtk_namestore_srv.c
  * @brief namestore plugin for editing SRV records
  * @author Christian Grothoff
+ *
+ * Please note that the code of this plugin (and its XML) is
+ * included in the BOX plugin (and Box XML) as well and thus
+ * particular care needs to be taken when changes are made
+ * to make sure names are consistent across the plugins.
  */
 #include "gnunet_gtk.h"
 #include "gnunet_gtk_namestore_plugin.h"




reply via email to

[Prev in Thread] Current Thread [Next in Thread]