[GNUnet-SVN] r34079 - gnunet/src/cadet

[gnunet]

Author: bartpolot
Date: 2014-07-30 10:21:49 +0200 (Wed, 30 Jul 2014)
New Revision: 34079

Modified:
   gnunet/src/cadet/gnunet-service-cadet_channel.c
Log:
- better feedback to users about duplicated messages

Modified: gnunet/src/cadet/gnunet-service-cadet_channel.c
===================================================================
--- gnunet/src/cadet/gnunet-service-cadet_channel.c     2014-07-30 08:21:48 UTC 
(rev 34078)
+++ gnunet/src/cadet/gnunet-service-cadet_channel.c     2014-07-30 08:21:49 UTC 
(rev 34079)
@@ -1972,10 +1972,26 @@
   }
   else
   {
-    GNUNET_break_op (GC_is_pid_bigger (rel->mid_recv, mid));
-    LOG (GNUNET_ERROR_TYPE_WARNING,
-         "MID %u on channel %s not expected (window: %u - %u). Dropping!\n",
-         mid, GCCH_2s (ch), rel->mid_recv, rel->mid_recv + 63);
+    if (GC_is_pid_bigger (rel->mid_recv, mid))
+    {
+      GNUNET_break_op (0);
+      LOG (GNUNET_ERROR_TYPE_WARNING,
+          "MID %u on channel %s not expected (window: %u - %u). Dropping!\n",
+          mid, GCCH_2s (ch), rel->mid_recv, rel->mid_recv + 63);
+    }
+    else
+    {
+      LOG (GNUNET_ERROR_TYPE_WARNING,
+           "Duplicate MID %u, channel %s (expecting MID %u). Re-sending 
ACK!\n",
+           mid, GCCH_2s (ch), rel->mid_recv);
+      if (NULL != rel->uniq)
+      {
+        LOG (GNUNET_ERROR_TYPE_WARNING,
+            "We are trying to send an ACK, but don't seem have the "
+            "bandwidth. Try to increase your ats QUOTA in you config file\n");
+      }
+
+    }
   }
 
   GCCH_send_data_ack (ch, fwd);