[GNUnet-SVN] r34352 - gnunet/src/conversation

[gnunet]

Author: grothoff
Date: 2014-10-05 14:26:40 +0200 (Sun, 05 Oct 2014)
New Revision: 34352

Modified:
   gnunet/src/conversation/gnunet-service-conversation.c
Log:
-fix use-after-free in error handling

Modified: gnunet/src/conversation/gnunet-service-conversation.c
===================================================================
--- gnunet/src/conversation/gnunet-service-conversation.c       2014-10-05 
12:24:20 UTC (rev 34351)
+++ gnunet/src/conversation/gnunet-service-conversation.c       2014-10-05 
12:26:40 UTC (rev 34352)
@@ -1046,7 +1046,8 @@
  * @param channel_ctx the channel context, can be NULL
  *                    or point to the `struct Channel`
  * @param message the incoming message
- * @return #GNUNET_OK
+ * @return #GNUNET_OK if message was OK,
+ *         #GNUNET_SYSERR if message violated the protocol
  */
 static int
 handle_cadet_pickup_message (void *cls,
@@ -1076,7 +1077,7 @@
   case CS_CALLEE_SHUTDOWN:
     GNUNET_break_op (0);
     destroy_line_cadet_channels (ch);
-    break;
+    return GNUNET_SYSERR;
   case CS_CALLER_CALLING:
     ch->status = CS_CALLER_CONNECTED;
     break;