[GNUnet-SVN] r34966 - gnunet/src/ats

[gnunet]

Author: grothoff
Date: 2015-01-22 23:13:42 +0100 (Thu, 22 Jan 2015)
New Revision: 34966

Modified:
   gnunet/src/ats/ats.h
   gnunet/src/ats/ats_api_scheduling.c
Log:
-improving docs

Modified: gnunet/src/ats/ats.h
===================================================================
--- gnunet/src/ats/ats.h        2015-01-22 21:49:42 UTC (rev 34965)
+++ gnunet/src/ats/ats.h        2015-01-22 22:13:42 UTC (rev 34966)
@@ -267,6 +267,32 @@
 
 
 /**
+ * Message sent by ATS service to client to confirm that it is done
+ * using the given session ID.
+ */
+struct SessionReleaseMessage
+{
+  /**
+   * Type is #GNUNET_MESSAGE_TYPE_ATS_SESSION_RELEASE.
+   */
+  struct GNUNET_MessageHeader header;
+
+  /**
+   * Number the client used to identify the session.
+   */
+  uint32_t session_id GNUNET_PACKED;
+
+  /**
+   * Which peer is this about? (Technically redundant, as the
+   * @e session_id should be sufficient, but may enable client
+   * to find the session faster).
+   */
+  struct GNUNET_PeerIdentity peer;
+};
+
+
+
+/**
  * ATS Service suggests to the transport service to use the address
  * identified by the given @e session_id for the given @e peer with
  * the given @e bandwidth_in and @e bandwidth_out limits from now on.
@@ -374,20 +400,7 @@
 };
 
 
-/**
- * Message sent by ATS service to client to confirm that it is done
- * using the given session ID.
- */
-struct SessionReleaseMessage
-{
-  struct GNUNET_MessageHeader header;
 
-  uint32_t session_id GNUNET_PACKED;
-
-  struct GNUNET_PeerIdentity peer;
-};
-
-
 struct ReservationResultMessage
 {
   struct GNUNET_MessageHeader header;

Modified: gnunet/src/ats/ats_api_scheduling.c
===================================================================
--- gnunet/src/ats/ats_api_scheduling.c 2015-01-22 21:49:42 UTC (rev 34965)
+++ gnunet/src/ats/ats_api_scheduling.c 2015-01-22 22:13:42 UTC (rev 34966)
@@ -22,6 +22,14 @@
  * @brief automatic transport selection and outbound bandwidth determination
  * @author Christian Grothoff
  * @author Matthias Wachs
+ *
+ * TODO:
+ * - we could avoid a linear scan over the
+ *   active addresses in some cases, so if
+ *   there is need, we can still optimize here
+ * - we might want to split off the logic to
+ *   determine LAN vs. WAN, as it has nothing
+ *   to do with accessing the ATS service.
  */
 #include "platform.h"
 #include "gnunet_ats_service.h"
@@ -40,11 +48,9 @@
 
 
 /**
- * Information we track per address.
- * FIXME: but what about *incoming* connections?
- *        "address" tells us about those, those
- *        are only valid while we have a session.
- *        Need to clarify all this!!!
+ * Information we track per address, incoming or outgoing.  It also
+ * doesn't matter if we have a session, any address that ATS is
+ * allowed to suggest right now should be tracked.
  */
 struct GNUNET_ATS_AddressRecord
 {
@@ -86,15 +92,16 @@
   uint32_t slot;
 
   /**
-   * Is this address currently in use?
-   * FIXME: document what "in use" means, and why it
-   * is important!
+   * Is this address currently in use?  In use means
+   * that the transport service will use this address
+   * for sending.
    */
   int in_use;
 
   /**
    * We're about to destroy this address record, just ATS does
-   * not know this yet.
+   * not know this yet.  Once ATS confirms its destruction,
+   * we can clean up.
    */
   int in_destroy;
 };
@@ -104,7 +111,10 @@
  * We keep a list of our local networks so we can answer
  * LAN vs. WAN questions.  Note: WLAN is not detected yet.
  * (maybe we can do that heuristically based on interface
- * name in the future?)
+ * name in the future?).
+ *
+ * FIXME: should this be part of the ATS scheduling API?
+ * Seems to be more generic and independent of ATS.
  */
 struct ATS_Network
 {
@@ -429,7 +439,8 @@
   const struct SessionReleaseMessage *srm;
 
   srm = (const struct SessionReleaseMessage *) msg;
-  /* FIXME: peer field in srm not necessary anymore */
+  /* Note: peer field in srm not necessary right now,
+     but might be good to have in the future */
   release_session (sh,
                    ntohl (srm->session_id));
 }