gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GNUnet-SVN] [taler-exchange] branch master updated (9f7e3bb -> ad850ce)


From: gnunet
Subject: [GNUnet-SVN] [taler-exchange] branch master updated (9f7e3bb -> ad850ce)
Date: Sun, 04 Jun 2017 11:33:53 +0200

This is an automated email from the git hooks/post-receive script.

grothoff pushed a change to branch master
in repository exchange.

    from 9f7e3bb  More on RSA-KTI
     new c7c7ac6  cleaning up use of doxygen, fixing #5057
     new 1e30d60  fixing misc doxygen issues
     new ad850ce  ignore generated file

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 .gitignore                                    |  1 +
 doc/doxygen/taler-exchange.doxy => Doxyfile   | 40 +++++++++----------
 Makefile.am                                   | 13 ++++++-
 configure.ac                                  | 43 +++++++++++++++++++--
 contrib/gnunet.tag                            | 55 +++++++++++++++++++++++++++
 contrib/microhttpd.tag                        | 44 +++++++++++++++++++++
 doc/Makefile.am                               |  2 +-
 doc/doxygen/Makefile.am                       | 18 ---------
 src/bank-lib/fakebank.c                       |  1 +
 src/exchange-lib/exchange_api_refresh.c       |  2 +-
 src/exchange/taler-exchange-httpd_parsing.c   |  4 +-
 src/exchange/taler-exchange-httpd_parsing.h   |  4 +-
 src/exchange/taler-exchange-httpd_responses.c |  2 +-
 src/exchange/taler-exchange-httpd_responses.h |  4 +-
 src/include/taler_crypto_lib.h                |  4 +-
 src/include/taler_exchange_service.h          |  2 +-
 src/pq/pq_query_helper.c                      |  8 ++--
 src/util/crypto.c                             |  6 +--
 18 files changed, 190 insertions(+), 63 deletions(-)
 rename doc/doxygen/taler-exchange.doxy => Doxyfile (92%)
 create mode 100644 contrib/gnunet.tag
 create mode 100644 contrib/microhttpd.tag
 delete mode 100644 doc/doxygen/Makefile.am

diff --git a/.gitignore b/.gitignore
index 8067993..7f0c79e 100644
--- a/.gitignore
+++ b/.gitignore
@@ -83,3 +83,4 @@ doc/manual/manual.pg
 doc/manual/manual.toc
 doc/manual/manual.tp
 doc/manual/manual.vr
+contrib/taler-exchange.tag
diff --git a/doc/doxygen/taler-exchange.doxy b/Doxyfile
similarity index 92%
rename from doc/doxygen/taler-exchange.doxy
rename to Doxyfile
index 23c2fbe..359c720 100644
--- a/doc/doxygen/taler-exchange.doxy
+++ b/Doxyfile
@@ -5,8 +5,8 @@
 #---------------------------------------------------------------------------
 DOXYFILE_ENCODING      = UTF-8
 PROJECT_NAME           = "GNU Taler: Exchange"
-PROJECT_NUMBER         = 0.0
-OUTPUT_DIRECTORY       = .
+PROJECT_NUMBER         = 0.3
+OUTPUT_DIRECTORY       = doxygen-doc/
 CREATE_SUBDIRS         = YES
 OUTPUT_LANGUAGE        = English
 BRIEF_MEMBER_DESC      = YES
@@ -25,9 +25,8 @@ ABBREVIATE_BRIEF       = "The $name class" \
 ALWAYS_DETAILED_SEC    = NO
 INLINE_INHERITED_MEMB  = NO
 FULL_PATH_NAMES        = YES
-STRIP_FROM_PATH        = ../..
-STRIP_FROM_INC_PATH    = ../../src/include \
-                        src/include
+STRIP_FROM_PATH        = .
+STRIP_FROM_INC_PATH    = src/include
 SHORT_NAMES            = NO
 JAVADOC_AUTOBRIEF      = NO
 QT_AUTOBRIEF           = NO
@@ -79,24 +78,24 @@ FILE_VERSION_FILTER    =
 #---------------------------------------------------------------------------
 # configuration options related to warning and progress messages
 #---------------------------------------------------------------------------
-QUIET                  = NO
+QUIET                  = YES
 WARNINGS               = YES
 WARN_IF_UNDOCUMENTED   = YES
 WARN_IF_DOC_ERROR      = YES
-WARN_NO_PARAMDOC       = NO
+WARN_NO_PARAMDOC       = YES
 WARN_FORMAT            = "$file:$line: $text"
 WARN_LOGFILE           =
 #---------------------------------------------------------------------------
 # configuration options related to the input files
 #---------------------------------------------------------------------------
-INPUT                  = ../..
+INPUT                  = src/
 INPUT_ENCODING         = UTF-8
 FILE_PATTERNS          = *.c \
                          *.h
 RECURSIVE              = YES
 EXCLUDE                =
 EXCLUDE_SYMLINKS       = NO
-EXCLUDE_PATTERNS       = */test_* */.svn/* */perf_* */tls_test_*  */examples/* 
taler_config.h
+EXCLUDE_PATTERNS       = */test_* */.git/* */perf_* */tls_test_*  
taler_config.h
 EXCLUDE_SYMBOLS        = GNUNET_* JSON_*
 EXAMPLE_PATH           =
 EXAMPLE_PATTERNS       = *
@@ -121,11 +120,11 @@ VERBATIM_HEADERS       = NO
 #---------------------------------------------------------------------------
 ALPHABETICAL_INDEX     = YES
 COLS_IN_ALPHA_INDEX    = 5
-IGNORE_PREFIX          =
+IGNORE_PREFIX          = TALER_
 #---------------------------------------------------------------------------
 # configuration options related to the HTML output
 #---------------------------------------------------------------------------
-GENERATE_HTML          = YES
+#GENERATE_HTML          = YES
 HTML_OUTPUT            = html
 HTML_FILE_EXTENSION    = .html
 HTML_HEADER            =
@@ -148,11 +147,11 @@ TREEVIEW_WIDTH         = 250
 #---------------------------------------------------------------------------
 # configuration options related to the LaTeX output
 #---------------------------------------------------------------------------
-GENERATE_LATEX         = NO
+#GENERATE_LATEX         = YES
 LATEX_OUTPUT           = latex
 LATEX_CMD_NAME         = latex
 MAKEINDEX_CMD_NAME     = makeindex
-COMPACT_LATEX          = NO
+COMPACT_LATEX          = YES
 PAPER_TYPE             = a4wide
 EXTRA_PACKAGES         =
 LATEX_HEADER           =
@@ -163,9 +162,9 @@ LATEX_HIDE_INDICES     = NO
 #---------------------------------------------------------------------------
 # configuration options related to the RTF output
 #---------------------------------------------------------------------------
-GENERATE_RTF           = NO
+#GENERATE_RTF           = NO
 RTF_OUTPUT             = rtf
-COMPACT_RTF            = NO
+COMPACT_RTF            = YES
 RTF_HYPERLINKS         = NO
 RTF_STYLESHEET_FILE    =
 RTF_EXTENSIONS_FILE    =
@@ -179,7 +178,7 @@ MAN_LINKS              = NO
 #---------------------------------------------------------------------------
 # configuration options related to the XML output
 #---------------------------------------------------------------------------
-GENERATE_XML           = NO
+#GENERATE_XML           = NO
 XML_OUTPUT             = xml
 XML_PROGRAMLISTING     = YES
 #---------------------------------------------------------------------------
@@ -208,15 +207,16 @@ SKIP_FUNCTION_MACROS   = YES
 #---------------------------------------------------------------------------
 # Configuration::additions related to external references
 #---------------------------------------------------------------------------
-TAGFILES               =
-GENERATE_TAGFILE       =
+TAGFILES               = contrib/gnunet.tag \
+                         contrib/microhttpd.tag
+GENERATE_TAGFILE       = contrib/taler-exchange.tag
 ALLEXTERNALS           = NO
 EXTERNAL_GROUPS        = YES
 PERL_PATH              = /usr/bin/perl
 #---------------------------------------------------------------------------
 # Configuration options related to the dot tool
 #---------------------------------------------------------------------------
-CLASS_DIAGRAMS         = YES
+CLASS_DIAGRAMS         = NO
 MSCGEN_PATH            =
 HIDE_UNDOC_RELATIONS   = YES
 HAVE_DOT               = YES
@@ -234,7 +234,7 @@ DIRECTORY_GRAPH        = YES
 DOT_IMAGE_FORMAT       = png
 DOT_PATH               =
 DOTFILE_DIRS           =
-DOT_GRAPH_MAX_NODES    = 25
+DOT_GRAPH_MAX_NODES    = 100
 MAX_DOT_GRAPH_DEPTH    = 2
 DOT_TRANSPARENT        = YES
 DOT_MULTI_TARGETS      = NO
diff --git a/Makefile.am b/Makefile.am
index 4bbc208..a73d4d8 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -1,10 +1,19 @@
 # This Makefile.am is in the public domain
 AM_CPPFLAGS = -I$(top_srcdir)/src/include
-SUBDIRS = src doc
+
+if DOC_ONLY
+  SUBDIRS = . doc
+else
+  SUBDIRS = . src doc
+endif
+
address@hidden@
+
 ACLOCAL_AMFLAGS = -I m4
 EXTRA_DIST = \
   AUTHORS \
-  contrib/coverage.sh
+  contrib/coverage.sh \
+  Doxyfile
 
 app:
        mkdir -p $(PACKAGE)-$(VERSION)-app
diff --git a/configure.ac b/configure.ac
index e258b52..715e94e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -30,10 +30,30 @@ AC_CONFIG_MACRO_DIR([m4])
 
 LT_INIT
 
+DX_INIT_DOXYGEN([taler-exchange],,,
+DX_PS_FEATURE(OFF),
+DX_PDF_FEATURE(OFF),
+DX_RTF_FEATURE(OFF),
+DX_CHI_FEATURE(OFF),
+DX_XML_FEATURE(OFF))
+
+AC_MSG_CHECKING([whether to compile documentation ONLY])
+AC_ARG_ENABLE([only-doc],
+  [AS_HELP_STRING([--enable-only-doc], [only compile Taler documentation])],
+  [doc_only=${enableval}],
+  [doc_only=no])
+AC_MSG_RESULT($doc_only)
+AM_CONDITIONAL([DOC_ONLY], [test "$doc_only" = "yes"])
+
+if test "$doc_only" != yes
+then
+
 # Checks for programs.
+
 AC_PROG_CC
 AC_PROG_CC_C99
 
+
 CFLAGS="-Wall $CFLAGS"
 
 # Checks for header files.
@@ -42,7 +62,7 @@ AC_CHECK_HEADERS([stdint.h stdlib.h string.h unistd.h])
 
 # should the build process be restricted to the code required
 # for GNU Taler wallets?
-AC_MSG_CHECKING(whether to compile GNU Taler Wallet library ONLY)
+AC_MSG_CHECKING([whether to compile GNU Taler Wallet library ONLY])
 AC_ARG_ENABLE([wallet],
    [AS_HELP_STRING([--enable-wallet], [only compile for Taler wallet])],
    [wallet_only=${enableval}],
@@ -276,6 +296,7 @@ LDFLAGS=$LDFLAGS_SAVE
 LIBS=$LIBS_SAVE
 
 
+# end of wallet/no-wallet specific logic
 fi
 
 TALER_LIB_LDFLAGS="-export-dynamic -no-undefined"
@@ -296,10 +317,10 @@ AM_CONDITIONAL(HAVE_POSTGRESQL, test x$postgres = xtrue)
 LIBGNURL_CHECK_CONFIG(,7.34.0,gnurl=1,gnurl=0)
 if test "$gnurl" = 1
 then
-       AM_CONDITIONAL(HAVE_LIBGNURL, true)
+       AM_CONDITIONAL(HAVE_LIBGNURL, [true])
        AC_DEFINE([HAVE_LIBGNURL],[1],[Have libgnurl])
 else
-       AM_CONDITIONAL(HAVE_LIBGNURL, false)
+       AM_CONDITIONAL(HAVE_LIBGNURL, [false])
 fi
 
 # libcurl-gnutls
@@ -447,9 +468,23 @@ AC_TYPE_UINTMAX_T
 # Checks for library functions.
 AC_CHECK_FUNCS([strdup])
 
+else
+
+# logic if doc_only is set, make sure conditionals are still defined
+AM_CONDITIONAL([HAVE_EXPENSIVE_TESTS], [false])
+AM_CONDITIONAL([WALLET_ONLY], [false])
+AM_CONDITIONAL([HAVE_POSTGRESQL], [false])
+AM_CONDITIONAL([HAVE_LIBCURL], [false])
+AM_CONDITIONAL([HAVE_LIBGNURL], [false])
+AM_CONDITIONAL([HAVE_DEVELOPER], [false])
+AM_CONDITIONAL([USE_COVERAGE], [false])
+
+
+# end of 'doc_only'
+fi
+
 AC_CONFIG_FILES([Makefile
                  doc/Makefile
-                 doc/doxygen/Makefile
                  src/Makefile
                  src/auditor/Makefile
                  src/auditordb/Makefile
diff --git a/contrib/gnunet.tag b/contrib/gnunet.tag
new file mode 100644
index 0000000..1cf4f0d
--- /dev/null
+++ b/contrib/gnunet.tag
@@ -0,0 +1,55 @@
+<?xml version='1.0' encoding='UTF-8' standalone='yes' ?>
+<tagfile>
+  <compound kind="file">
+    <name>gnunet_util_lib.h</name>
+    <path></path>
+    <filename>gnunet_util_lib.h</filename>
+    <member kind="define">
+      <type>#define</type>
+      <name>GNUNET_YES</name>
+      <anchorfile>gnunet_util_lib.h</anchorfile>
+      <arglist></arglist>
+    </member>
+    <member kind="define">
+      <type>#define</type>
+      <name>GNUNET_OK</name>
+      <anchorfile>gnunet_util_lib.h</anchorfile>
+      <arglist></arglist>
+    </member>
+    <member kind="define">
+      <type>#define</type>
+      <name>GNUNET_NO</name>
+      <anchorfile>gnunet_util_lib.h</anchorfile>
+      <arglist></arglist>
+    </member>
+    <member kind="define">
+      <type>#define</type>
+      <name>GNUNET_SYSERR</name>
+      <anchorfile>gnunet_util_lib.h</anchorfile>
+      <arglist></arglist>
+    </member>
+    <member kind="define">
+      <type>#define</type>
+      <name>GNUNET_TIME_UNIT_FOREVER_ABS</name>
+      <anchorfile>gnunet_util_lib.h</anchorfile>
+      <arglist></arglist>
+    </member>
+  </compound>
+  <compound kind="file">
+    <name>gnunet_pq_lib.h</name>
+    <path></path>
+    <filename>gnunet_pq_lib.h</filename>
+    <member kind="define">
+      <type>#define</type>
+      <name>GNUNET_PQ_query_param_end</name>
+      <anchorfile>gnunet_pq_lib.h</anchorfile>
+      <arglist></arglist>
+    </member>
+    <member kind="typedef">
+      <type>int</type>
+      <name>GNUNET_PQ_ResultConverter</name>
+      <anchorfile>gnunet_pq_lib.h</anchorfile>
+      <arglist>)(void *cls, PGresult *result, int row, const char *fname, 
size_t *dst_size, void *dst)</arglist>
+    </member>
+  </compound>
+</tagfile>
diff --git a/contrib/microhttpd.tag b/contrib/microhttpd.tag
new file mode 100644
index 0000000..de7018a
--- /dev/null
+++ b/contrib/microhttpd.tag
@@ -0,0 +1,44 @@
+<?xml version='1.0' encoding='UTF-8' standalone='yes' ?>
+<tagfile>
+  <compound kind="file">
+    <name>microhttpd_lib.h</name>
+    <path></path>
+    <filename>microhttpd.h</filename>
+    <member kind="define">
+      <type>#define</type>
+      <name>MHD_YES</name>
+      <anchorfile>microhttpd.h</anchorfile>
+      <arglist></arglist>
+    </member>
+    <member kind="define">
+      <type>#define</type>
+      <name>MHD_NO</name>
+      <anchorfile>microhttpd.h</anchorfile>
+      <arglist></arglist>
+    </member>
+    <member kind="define">
+      <type>#define</type>
+      <name>MHD_HTTP_OK</name>
+      <anchorfile>microhttpd.h</anchorfile>
+      <arglist></arglist>
+    </member>
+    <member kind="define">
+      <type>#define</type>
+      <name>MHD_HTTP_NO_CONTENT</name>
+      <anchorfile>microhttpd.h</anchorfile>
+      <arglist></arglist>
+    </member>
+    <member kind="define">
+      <type>#define</type>
+      <name>MHD_OPTION_NOTIFY_COMPLETED</name>
+      <anchorfile>microhttpd.h</anchorfile>
+      <arglist></arglist>
+    </member>
+    <member kind="typedef">
+      <type>int</type>
+      <name>MHD_AccessHandlerCallback</name>
+      <anchorfile>microhttpd.h</anchorfile>
+      <arglist>)(void *cls, struct MHD_Connection *connection, const char 
*url, const char *method, const char *version, const char *upload_data, size_t 
*upload_data_size, void **con_cls)</arglist>
+    </member>
+  </compound>
+</tagfile>
diff --git a/doc/Makefile.am b/doc/Makefile.am
index c509f4a..f8d04db 100644
--- a/doc/Makefile.am
+++ b/doc/Makefile.am
@@ -1,6 +1,6 @@
 # This Makefile.am is in the public domain
 
-SUBDIRS = . doxygen
+SUBDIRS = .
 
 man_MANS = \
   taler-auditor.1 \
diff --git a/doc/doxygen/Makefile.am b/doc/doxygen/Makefile.am
deleted file mode 100644
index da4dbc1..0000000
--- a/doc/doxygen/Makefile.am
+++ /dev/null
@@ -1,18 +0,0 @@
-# This Makefile.am is in the public domain
-all:
-       @echo -e \
-"Generate documentation:\n" \
-"\tmake full - full documentation with dependency graphs (slow)\n" \
-"\tmake fast - fast mode without dependency graphs"
-
-full: taler-exchange.doxy
-       doxygen $<
-
-fast: taler-exchange.doxy
-       sed 's/\(HAVE_DOT.*=\).*/\1 NO/' $< | doxygen -
-
-clean:
-       rm -rf html
-
-
-EXTRA_DIST = taler-exchange.doxy
diff --git a/src/bank-lib/fakebank.c b/src/bank-lib/fakebank.c
index 813d5b2..924e065 100644
--- a/src/bank-lib/fakebank.c
+++ b/src/bank-lib/fakebank.c
@@ -393,6 +393,7 @@ handle_admin_add_incoming (struct TALER_FAKEBANK_Handle *h,
  *
  * @param h the fakebank handle
  * @param connection the connection
+ * @param con_cls place to store state, not used
  * @return MHD result code
  */
 static int
diff --git a/src/exchange-lib/exchange_api_refresh.c 
b/src/exchange-lib/exchange_api_refresh.c
index 84fb3b7..79381f3 100644
--- a/src/exchange-lib/exchange_api_refresh.c
+++ b/src/exchange-lib/exchange_api_refresh.c
@@ -690,7 +690,7 @@ deserialize_melt_data (const char *buf,
  *         if the inputs are invalid (i.e. denomination key not with this 
exchange).
  *         Otherwise, pointer to a buffer of @a res_size to store persistently
  *         before proceeding to #TALER_EXCHANGE_refresh_melt().
- *         Non-null results should be freed using #GNUNET_free().
+ *         Non-null results should be freed using GNUNET_free().
  */
 char *
 TALER_EXCHANGE_refresh_prepare (const struct TALER_CoinSpendPrivateKeyP 
*melt_priv,
diff --git a/src/exchange/taler-exchange-httpd_parsing.c 
b/src/exchange/taler-exchange-httpd_parsing.c
index e9c38eb..4d7b5ab 100644
--- a/src/exchange/taler-exchange-httpd_parsing.c
+++ b/src/exchange/taler-exchange-httpd_parsing.c
@@ -174,7 +174,7 @@ TEH_PARSE_mhd_request_arg_data (struct MHD_Connection 
*connection,
  * @return
  *    #GNUNET_YES if navigation was successful (caller is responsible
  *                for freeing allocated variable-size data using
- *                #GNUNET_JSON_parse_free() when done)
+ *                GNUNET_JSON_parse_free() when done)
  *    #GNUNET_NO if json is malformed, error response was generated
  *    #GNUNET_SYSERR on internal error
  */
@@ -221,7 +221,7 @@ TEH_PARSE_json_data (struct MHD_Connection *connection,
  * @return
  *    #GNUNET_YES if navigation was successful (caller is responsible
  *                for freeing allocated variable-size data using
- *                #GNUNET_JSON_parse_free() when done)
+ *                GNUNET_JSON_parse_free() when done)
  *    #GNUNET_NO if json is malformed, error response was generated
  *    #GNUNET_SYSERR on internal error
  */
diff --git a/src/exchange/taler-exchange-httpd_parsing.h 
b/src/exchange/taler-exchange-httpd_parsing.h
index bd705d5..9c53817 100644
--- a/src/exchange/taler-exchange-httpd_parsing.h
+++ b/src/exchange/taler-exchange-httpd_parsing.h
@@ -82,7 +82,7 @@ TEH_PARSE_post_cleanup_callback (void *con_cls);
  * @return
  *    #GNUNET_YES if navigation was successful (caller is responsible
  *                for freeing allocated variable-size data using
- *                #GNUNET_JSON_parse_free() when done)
+ *                GNUNET_JSON_parse_free() when done)
  *    #GNUNET_NO if json is malformed, error response was generated
  *    #GNUNET_SYSERR on internal error
  */
@@ -103,7 +103,7 @@ TEH_PARSE_json_data (struct MHD_Connection *connection,
  * @return
  *    #GNUNET_YES if navigation was successful (caller is responsible
  *                for freeing allocated variable-size data using
- *                #GNUNET_JSON_parse_free() when done)
+ *                GNUNET_JSON_parse_free() when done)
  *    #GNUNET_NO if json is malformed, error response was generated
  *    #GNUNET_SYSERR on internal error
  */
diff --git a/src/exchange/taler-exchange-httpd_responses.c 
b/src/exchange/taler-exchange-httpd_responses.c
index 0eebda6..346f620 100644
--- a/src/exchange/taler-exchange-httpd_responses.c
+++ b/src/exchange/taler-exchange-httpd_responses.c
@@ -84,7 +84,7 @@ TEH_RESPONSE_can_compress (struct MHD_Connection *connection)
  *
  * @param[in,out] buf pointer to body to compress
  * @param[in,out] buf_size pointer to initial size of @a buf
- * @return #MHD_TES if @a buf was compressed
+ * @return #MHD_YES if @a buf was compressed
  */
 int
 TEH_RESPONSE_body_compress (void **buf,
diff --git a/src/exchange/taler-exchange-httpd_responses.h 
b/src/exchange/taler-exchange-httpd_responses.h
index ccd1188..6a33b65 100644
--- a/src/exchange/taler-exchange-httpd_responses.h
+++ b/src/exchange/taler-exchange-httpd_responses.h
@@ -50,14 +50,14 @@ TEH_RESPONSE_add_global_headers (struct MHD_Response 
*response);
  *
  * @param[in,out] buf pointer to body to compress
  * @param[in,out] buf_size pointer to initial size of @a buf
- * @return #MHD_TES if @a buf was compressed
+ * @return #MHD_YES if @a buf was compressed
  */
 int
 TEH_RESPONSE_body_compress (void **buf,
                            size_t *buf_size);
 
 
-/** 
+/**
  * Is HTTP body deflate compression supported by the client?
  *
  * @param connection connection to check
diff --git a/src/include/taler_crypto_lib.h b/src/include/taler_crypto_lib.h
index 9c854ab..9e9352f 100644
--- a/src/include/taler_crypto_lib.h
+++ b/src/include/taler_crypto_lib.h
@@ -390,7 +390,7 @@ struct TALER_TrackTransferDetails
  * @param coin_public_info the coin public info to check for validity
  * @return #GNUNET_YES if the coin is valid,
  *         #GNUNET_NO if it is invalid
- *         #GNUNET_SYSERROR if an internal error occured
+ *         #GNUNET_SYSERR if an internal error occured
  */
 int
 TALER_test_coin_valid (const struct TALER_CoinPublicInfo *coin_public_info);
@@ -409,7 +409,7 @@ struct TALER_TransferSecretP
   /**
    * Secret used to derive private inputs for refreshed coins.
    * Must be (currently) a hash as this is what
-   * #GNUNET_CRYPTO_ecc_ecdh() returns to us.
+   * GNUNET_CRYPTO_ecc_ecdh() returns to us.
    */
   struct GNUNET_HashCode key;
 };
diff --git a/src/include/taler_exchange_service.h 
b/src/include/taler_exchange_service.h
index b60b97e..7114aa6 100644
--- a/src/include/taler_exchange_service.h
+++ b/src/include/taler_exchange_service.h
@@ -970,7 +970,7 @@ TALER_EXCHANGE_reserve_withdraw_cancel (struct 
TALER_EXCHANGE_ReserveWithdrawHan
  *         if the inputs are invalid (i.e. denomination key not with this 
exchange).
  *         Otherwise, pointer to a buffer of @a res_size to store persistently
  *         before proceeding to #TALER_EXCHANGE_refresh_melt().
- *         Non-null results should be freed using #GNUNET_free().
+ *         Non-null results should be freed using GNUNET_free().
  */
 char *
 TALER_EXCHANGE_refresh_prepare (const struct TALER_CoinSpendPrivateKeyP 
*melt_priv,
diff --git a/src/pq/pq_query_helper.c b/src/pq/pq_query_helper.c
index bbfa0ee..d6418a1 100644
--- a/src/pq/pq_query_helper.c
+++ b/src/pq/pq_query_helper.c
@@ -36,7 +36,7 @@
  * @param[out] param_lengths SQL length data to set
  * @param[out] param_formats SQL format data to set
  * @param param_length number of entries available in the @a param_values, @a 
param_lengths and @a param_formats arrays
- * @param[out] scratch buffer for dynamic allocations (to be done via 
#GNUNET_malloc()
+ * @param[out] scratch buffer for dynamic allocations (to be done via 
GNUNET_malloc()
  * @param scratch_length number of entries left in @a scratch
  * @return -1 on error, number of offsets used in @a scratch otherwise
  */
@@ -98,7 +98,7 @@ TALER_PQ_query_param_amount_nbo (const struct TALER_AmountNBO 
*x)
  * @param[out] param_lengths SQL length data to set
  * @param[out] param_formats SQL format data to set
  * @param param_length number of entries available in the @a param_values, @a 
param_lengths and @a param_formats arrays
- * @param[out] scratch buffer for dynamic allocations (to be done via 
#GNUNET_malloc()
+ * @param[out] scratch buffer for dynamic allocations (to be done via 
GNUNET_malloc()
  * @param scratch_length number of entries left in @a scratch
  * @return -1 on error, number of offsets used in @a scratch otherwise
  */
@@ -161,7 +161,7 @@ TALER_PQ_query_param_amount (const struct TALER_Amount *x)
  * @param[out] param_lengths SQL length data to set
  * @param[out] param_formats SQL format data to set
  * @param param_length number of entries available in the @a param_values, @a 
param_lengths and @a param_formats arrays
- * @param[out] scratch buffer for dynamic allocations (to be done via 
#GNUNET_malloc()
+ * @param[out] scratch buffer for dynamic allocations (to be done via 
GNUNET_malloc()
  * @param scratch_length number of entries left in @a scratch
  * @return -1 on error, number of offsets used in @a scratch otherwise
  */
@@ -178,7 +178,7 @@ qconv_json (void *cls,
 {
   const json_t *json = data;
   char *str;
-  
+
   str = json_dumps (json, JSON_COMPACT);
   if (NULL == str)
     return -1;
diff --git a/src/util/crypto.c b/src/util/crypto.c
index d20c9a9..ce5bfac 100644
--- a/src/util/crypto.c
+++ b/src/util/crypto.c
@@ -79,7 +79,7 @@ TALER_gcrypt_init ()
  * @param coin_public_info the coin public info to check for validity
  * @return #GNUNET_YES if the coin is valid,
  *         #GNUNET_NO if it is invalid
- *         #GNUNET_SYSERROR if an internal error occured
+ *         #GNUNET_SYSERR if an internal error occured
  */
 int
 TALER_test_coin_valid (const struct TALER_CoinPublicInfo *coin_public_info)
@@ -205,10 +205,10 @@ TALER_setup_fresh_coin (const struct 
TALER_TransferSecretP *secret_seed,
   p[31] &= 0xf8; /* Clear bits 2..0 so that d mod 8 == 0  */
 
   /* FIXME: Run GNUNET_CRYPTO_ecdhe_key_create several times and inspect
-   * the output to verify that the same bits are set and cleared.  
+   * the output to verify that the same bits are set and cleared.
    * Is it worth also adding a test case that runs gcry_pk_testkey on
    * this key after first parsing it into libgcrypt's s-expression mess
-   * ala decode_private_eddsa_key from gnunet/src/util/crypto_ecc.c? 
+   * ala decode_private_eddsa_key from gnunet/src/util/crypto_ecc.c?
    * It'd run check_secret_key but not test_keys from libgcrypt/cipher/ecc.c */
 }
 

-- 
To stop receiving notification emails like this one, please contact
address@hidden



reply via email to

[Prev in Thread] Current Thread [Next in Thread]