[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[GNUnet-SVN] [gnurl] 133/254: tests: made a couple of prechecks consiste
From: |
gnunet |
Subject: |
[GNUnet-SVN] [gnurl] 133/254: tests: made a couple of prechecks consistent with others |
Date: |
Sat, 17 Jun 2017 16:52:45 +0200 |
This is an automated email from the git hooks/post-receive script.
ng0 pushed a commit to annotated tag gnurl-7.54.1
in repository gnurl.
commit fa0ac3f4d9ca095c33bca62ba2f64c95e3c3456a
Author: Dan Fandrich <address@hidden>
AuthorDate: Sat May 13 19:04:10 2017 +0200
tests: made a couple of prechecks consistent with others
Also removed a TODO suggesting caching the precheck results. Tests
showed this would save about 0.1 sec on the total test run time on a
relatively modern system, an unnoticeable gain at the cost of longer and
more complicated code. There would also be a danger that a cached test
result would be inappropriately returned, such as when other test
dependencies (like environment variables) are different or when the
precheck causes side effects (like filesystem changes).
---
tests/data/test1105 | 2 +-
tests/data/test31 | 2 +-
tests/runtests.pl | 5 -----
3 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/tests/data/test1105 b/tests/data/test1105
index 76ac4500a..4b5e0c836 100644
--- a/tests/data/test1105
+++ b/tests/data/test1105
@@ -35,7 +35,7 @@ HTTP with cookie parser and header recording
"http://%HOSTIP:%HTTPPORT/we/want/1105?parm1=this*that/other/thing&parm2=foobar/1105"
-c log/cookie1105.txt -d "userid=myname&password=mypassword"
</command>
<precheck>
-perl -e 'if ("%HOSTIP" !~ /127\.0\.0\.1$/) {print "Test only works for HOSTIP
127.0.0.1"; exit(1)}'
+perl -e "print 'Test requires default test server host' if ( '%HOSTIP' ne
'127.0.0.1' );"
</precheck>
</client>
diff --git a/tests/data/test31 b/tests/data/test31
index 2289d56d7..54e360a46 100644
--- a/tests/data/test31
+++ b/tests/data/test31
@@ -80,7 +80,7 @@ TZ=GMT
http://%HOSTIP:%HTTPPORT/we/want/31 -b none -c log/jar31.txt
</command>
<precheck>
-perl -e 'if ("%HOSTIP" !~ /127\.0\.0\.1$/) {print "Test only works for HOSTIP
127.0.0.1"; exit(1)}'
+perl -e "print 'Test requires default test server host' if ( '%HOSTIP' ne
'127.0.0.1' );"
</precheck>
</client>
diff --git a/tests/runtests.pl b/tests/runtests.pl
index d20383ae8..f23fc1d68 100755
--- a/tests/runtests.pl
+++ b/tests/runtests.pl
@@ -3279,11 +3279,6 @@ sub singletest {
}
if(!$why) {
- # TODO:
- # Add a precheck cache. If a precheck command was already invoked
- # exactly like this, then use the previous result to speed up
- # successive test invokes!
-
my @precheck = getpart("client", "precheck");
if(@precheck) {
$cmd = $precheck[0];
--
To stop receiving notification emails like this one, please contact
address@hidden
- [GNUnet-SVN] [gnurl] 110/254: RELEASE-NOTES: synced with e3f84efc32d6b01a, (continued)
- [GNUnet-SVN] [gnurl] 110/254: RELEASE-NOTES: synced with e3f84efc32d6b01a, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 117/254: tests: updated for modified fake random, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 194/254: CURLOPT_STREAM_DEPENDS.3: typo, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 124/254: tests: remove superfluous test 1399, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 131/254: multi: remove leftover debug infof() calls from e9fd794a6, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 51/254: tool: Fix missing prototype warnings for CURL_DOES_CONVERSIONS, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 43/254: unit1604: fixed indentation, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 220/254: CONTRIBUTE.md: mention tests done on pull requests, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 141/254: man pages: fix example syntax errors, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 137/254: url.c: add a compile-time check that CURL_MAX_WRITE_SIZE is large enough, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 133/254: tests: made a couple of prechecks consistent with others,
gnunet <=
- [GNUnet-SVN] [gnurl] 210/254: mbedtls: make TU-local variable static, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 243/254: gitignore: ignore all vim swap files, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 68/254: sendf: remove use of BUFSIZE from debug data conversions, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 197/254: examples/externalsocket.c: s/closesocket/closecb, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 201/254: typecheck-gcc.h: check CURLINFO_TLS_SSL_PTR and CURLINFO_TLS_SESSION, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 253/254: release: 7.54.1, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 97/254: docs/opts: 24 more man pages now have examples, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 74/254: testpart: remove _MPRINTF_REPLACE, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 193/254: CURLOPT_FNMATCH_FUNCTION.3: also modified example to avoid fcpp issues, gnunet, 2017/06/17
- [GNUnet-SVN] [gnurl] 222/254: curl_ntlm_core: pass unsigned char to toupper, gnunet, 2017/06/17