gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GNUnet-SVN] [gnurl] 180/254: test557: fix ubsan runtime error due to in


From: gnunet
Subject: [GNUnet-SVN] [gnurl] 180/254: test557: fix ubsan runtime error due to int left shift
Date: Sat, 17 Jun 2017 16:53:32 +0200

This is an automated email from the git hooks/post-receive script.

ng0 pushed a commit to annotated tag gnurl-7.54.1
in repository gnurl.

commit 35682764a9dc7eb0fed3fbb1c0074f1c34dd60b2
Author: Jay Satiro <address@hidden>
AuthorDate: Mon May 29 18:04:53 2017 -0400

    test557: fix ubsan runtime error due to int left shift
    
    - Test curl_msnprintf negative int width arg using INT_MIN instead of
      1 << 31 which is undefined behavior.
    
    Closes https://github.com/curl/curl/issues/1516
---
 tests/libtest/lib557.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/tests/libtest/lib557.c b/tests/libtest/lib557.c
index ca3118aec..4a598f22d 100644
--- a/tests/libtest/lib557.c
+++ b/tests/libtest/lib557.c
@@ -27,6 +27,10 @@
 
 #include "test.h"
 
+#ifdef HAVE_LIMITS_H
+#include <limits.h>
+#endif
+
 #ifdef HAVE_LOCALE_H
 #  include <locale.h> /* for setlocale() */
 #endif
@@ -1621,8 +1625,8 @@ static int test_float_formatting(void)
                  123456789123456789123456789.2987654);
   errors += strlen_check(buf, 325);
 
-  /* 1<<31 turns negative (-2147483648) when used signed */
-  curl_msnprintf(buf, sizeof(buf), "%*f", (1<<31), 9.1);
+  /* check negative when used signed */
+  curl_msnprintf(buf, sizeof(buf), "%*f", INT_MIN, 9.1);
   errors += string_check(buf, "9.100000");
 
   /* curl_msnprintf() limits a single float output to 325 bytes maximum

-- 
To stop receiving notification emails like this one, please contact
address@hidden



reply via email to

[Prev in Thread] Current Thread [Next in Thread]