[GNUnet-SVN] [gnurl] 204/256: curl: make str2udouble not return values on error

[gnunet]

This is an automated email from the git hooks/post-receive script.

ng0 pushed a commit to branch master
in repository gnurl.

commit 697271fc980331ffb53f12850f82c80ed182a375
Author: Daniel Stenberg <address@hidden>
AuthorDate: Fri Sep 15 16:38:48 2017 +0200

    curl: make str2udouble not return values on error
    
    ... previously it would store a return value even when it returned
    error, which could make the value get used anyway!
    
    Reported-by: Brian Carpenter
    Closes #1893
---
 src/tool_paramhlp.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/tool_paramhlp.c b/src/tool_paramhlp.c
index 42631e9c3..7cddf51ce 100644
--- a/src/tool_paramhlp.c
+++ b/src/tool_paramhlp.c
@@ -242,14 +242,16 @@ static ParameterError str2double(double *val, const char 
*str, long max)
  * data.
  */
 
-ParameterError str2udouble(double *val, const char *str, long max)
+ParameterError str2udouble(double *valp, const char *str, long max)
 {
-  ParameterError result = str2double(val, str, max);
+  double value;
+  ParameterError result = str2double(&value, str, max);
   if(result != PARAM_OK)
     return result;
-  if(*val < 0)
+  if(value < 0)
     return PARAM_NEGATIVE_NUMERIC;
 
+  *valp = value;
   return PARAM_OK;
 }
 

-- 
To stop receiving notification emails like this one, please contact
address@hidden