[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[GNUnet-SVN] [gnurl] 182/256: checksrc: verify spaces around equals sign
From: |
gnunet |
Subject: |
[GNUnet-SVN] [gnurl] 182/256: checksrc: verify spaces around equals signs |
Date: |
Fri, 06 Oct 2017 19:44:33 +0200 |
This is an automated email from the git hooks/post-receive script.
ng0 pushed a commit to branch master
in repository gnurl.
commit e155f38d1eaa89cc8ce2a6536b74be2954506bb0
Author: Daniel Stenberg <address@hidden>
AuthorDate: Sat Sep 9 11:57:17 2017 +0200
checksrc: verify spaces around equals signs
... as the code style mandates.
---
lib/checksrc.pl | 18 +++++++++++++++++-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/lib/checksrc.pl b/lib/checksrc.pl
index b9fa9362f..f4ffa1ef3 100755
--- a/lib/checksrc.pl
+++ b/lib/checksrc.pl
@@ -58,7 +58,9 @@ my %warnings = (
'OPENCOMMENT' => 'file ended with a /* comment still "open"',
'ASTERISKSPACE' => 'pointer declared with space after asterisk',
'ASTERISKNOSPACE' => 'pointer declared without space before asterisk',
- 'ASSIGNWITHINCONDITION' => 'assignment within conditional expression'
+ 'ASSIGNWITHINCONDITION' => 'assignment within conditional expression',
+ 'EQUALSNOSPACE' => 'equals sign without following space',
+ 'NOSPACEEQUALS' => 'equals sign without preceeding space',
);
sub readwhitelist {
@@ -526,6 +528,20 @@ sub scanfile {
"wrongly placed open brace");
}
}
+
+ # check for equals sign without spaces next to it
+ if($nostr =~ /(.*)\=[a-z0-9]/i) {
+ checkwarn("EQUALSNOSPACE",
+ $line, length($1)+1, $file, $ol,
+ "no space after equals sign");
+ }
+ # check for equals sign without spaces before it
+ elsif($nostr =~ /(.*)[a-z0-9]\=/i) {
+ checkwarn("NOSPACEEQUALS",
+ $line, length($1)+1, $file, $ol,
+ "no space before equals sign");
+ }
+
$line++;
$prevl = $ol;
}
--
To stop receiving notification emails like this one, please contact
address@hidden
- [GNUnet-SVN] [gnurl] 252/256: idn: fix source code comment, (continued)
- [GNUnet-SVN] [gnurl] 252/256: idn: fix source code comment, gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 135/256: lib: bump version info (soname). Adapt and reenable test 1135., gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 193/256: tests: add initial gssapi test using stub implementation, gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 226/256: tests: fix a compiler warning in test 643, gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 235/256: docs: link CURLOPT_CONNECTTIMEOUT and CURLOPT_CONNECTTIMEOUT_MS, gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 227/256: file_range: avoid integer overflow when figuring out byte range, gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 218/256: form/mime: field names are not allowed to contain zero-valued bytes., gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 197/256: escape.c: error: pointer targets differ in signedness, gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 243/256: TODO: remove deprecated form API items., gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 187/256: code style: use space after semicolon, gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 182/256: checksrc: verify spaces around equals signs,
gnunet <=
- [GNUnet-SVN] [gnurl] 209/256: ossfuzz: changes before merging the generated corpora, gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 255/256: RELEASE-NOTES: curl 7.56.0, gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 232/256: reuse_conn: don't copy flags that are known to be equal, gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 186/256: checksrc: verify space after semicolons, gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 231/256: curl.h: include <sys/select.h> on cygwin too, gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 215/256: mime: rephrase the multipart output state machine (#1898) ..., gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 161/256: vtls: select ssl backend case-insensitive (follow-up), gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 174/256: form API: add new test 650., gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 223/256: ntlm: use strict order for SSL backend #if branches, gnunet, 2017/10/06
- [GNUnet-SVN] [gnurl] 178/256: rtsp: do not call fwrite() with NULL pointer FILE *, gnunet, 2017/10/06