gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[GNUnet-SVN] [gnurl] 51/116: url: remove arg value check from CURLOPT_SS


From: gnunet
Subject: [GNUnet-SVN] [gnurl] 51/116: url: remove arg value check from CURLOPT_SSH_AUTH_TYPES
Date: Tue, 05 Dec 2017 14:51:21 +0100

This is an automated email from the git hooks/post-receive script.

ng0 pushed a commit to branch master
in repository gnurl.

commit 462f3cac34c09b9c28b449258e71dc37171dc604
Author: Jay Satiro <address@hidden>
AuthorDate: Sat Nov 4 18:36:07 2017 -0400

    url: remove arg value check from CURLOPT_SSH_AUTH_TYPES
    
    Since CURLSSH_AUTH_ANY (aka CURLSSH_AUTH_DEFAULT) is ~0 an arg value
    check on this option is incorrect; we have to accept any value.
    
    Prior to this change since f121575 (7.56.1+) CURLOPT_SSH_AUTH_TYPES
    erroneously rejected CURLSSH_AUTH_ANY with CURLE_BAD_FUNCTION_ARGUMENT.
    
    Bug: https://github.com/curl/curl/commit/f121575#commitcomment-25347120
---
 lib/url.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/lib/url.c b/lib/url.c
index c3fb297d2..374ac6cfa 100644
--- a/lib/url.c
+++ b/lib/url.c
@@ -2710,10 +2710,7 @@ CURLcode Curl_setopt(struct Curl_easy *data, CURLoption 
option,
 #ifdef USE_LIBSSH2
     /* we only include SSH options if explicitly built to support SSH */
   case CURLOPT_SSH_AUTH_TYPES:
-    arg = va_arg(param, long);
-    if(arg < CURLSSH_AUTH_NONE)
-      return CURLE_BAD_FUNCTION_ARGUMENT;
-    data->set.ssh_auth_types = arg;
+    data->set.ssh_auth_types = va_arg(param, long);
     break;
 
   case CURLOPT_SSH_PUBLIC_KEYFILE:

-- 
To stop receiving notification emails like this one, please contact
address@hidden



reply via email to

[Prev in Thread] Current Thread [Next in Thread]