[GNUnet-SVN] [taler-merchant] annotated tag v0.5.0 updated (8a1df38 -> 971e2a1)

[gnunet]

This is an automated email from the git hooks/post-receive script.

dold pushed a change to annotated tag v0.5.0
in repository merchant.

*** WARNING: tag v0.5.0 was modified! ***

    from 8a1df38  (tag)
      to 971e2a1  (tag)
 tagging e248e97cbf0bf0d2f2f1870515de54c574f4b175 (commit)
 replaces v0.3.0
      by Florian Dold
      on Wed Apr 4 18:12:35 2018 +0200

- Log -----------------------------------------------------------------
Official release v0.5.0
-----------------------------------------------------------------------

 discard 4f0abc4  change version number to 0.5
 discard aac2ff6  avoid undefined behavior again, return correct right status 
early
 discard 9f7fda4  avoid undefined behavior
 discard 5a3f7d1  compute reserve expiration time properly
     add ccfc69e  declare var at beginning of scope...
     add 1530104  compute reserve expiration time properly
     add 46b0b7e  avoid undefined behavior
     add e80f144  avoid undefined behavior again, return correct right status 
early
     add 14b02be  should be fixme, not preprocessor warning
     add e248e97  change version number to 0.5

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
annotated tag are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (8a1df38)
            \
             N -- N -- N   refs/tags/v0.5.0 (971e2a1)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

No new revisions were added by this update.

Summary of changes:
 src/backenddb/plugin_merchantdb_postgres.c | 9 ++++-----
 src/lib/testing_api_cmd_tip.c              | 2 +-
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/backenddb/plugin_merchantdb_postgres.c 
b/src/backenddb/plugin_merchantdb_postgres.c
index 1d23d4d..b627718 100644
--- a/src/backenddb/plugin_merchantdb_postgres.c
+++ b/src/backenddb/plugin_merchantdb_postgres.c
@@ -2506,17 +2506,17 @@ process_deposits_for_refund_cb (void *cls,
                                unsigned int num_results)
 {
   struct InsertRefundContext *ctx = cls;
-  struct TALER_Amount current_refund;
 
   if (0 == num_results)
   {
     ctx->qs = GNUNET_DB_STATUS_SUCCESS_NO_RESULTS;
+    /* We must return early here, or the zero-length variable size arrays below
+       will be undefined behavior */
     return;
   }
 
   {
-    /* note that these must be declared here, since wiht num_results=0
-     * it would be undefined behavior. */
+    struct TALER_Amount current_refund;
     struct TALER_Amount deposit_refund[num_results];
     struct TALER_CoinSpendPublicKeyP deposit_coin_pubs[num_results];
     struct TALER_Amount deposit_amount_with_fee[num_results];
@@ -2619,6 +2619,7 @@ process_deposits_for_refund_cb (void *cls,
     {
       const struct TALER_Amount *increment;
       struct TALER_Amount left;
+      struct TALER_Amount remaining_refund;
 
       /* How much of the coin is left after the existing refunds? */
       if (GNUNET_SYSERR ==
@@ -2641,8 +2642,6 @@ process_deposits_for_refund_cb (void *cls,
         continue;
       }
 
-      struct TALER_Amount remaining_refund;
-
       /* How much of the refund is left? */
       if (GNUNET_SYSERR ==
           TALER_amount_subtract (&remaining_refund,
diff --git a/src/lib/testing_api_cmd_tip.c b/src/lib/testing_api_cmd_tip.c
index b04db4e..e9443e8 100644
--- a/src/lib/testing_api_cmd_tip.c
+++ b/src/lib/testing_api_cmd_tip.c
@@ -823,7 +823,7 @@ tip_pickup_cleanup (void *cls,
                     const struct TALER_TESTING_Command *cmd)
 {
   struct TipPickupState *tps = cls;
-  #warning free elements *in* the state!
+  /* FIXME:  free elements *in* the state! */
   if (NULL != tps->tpo)
   {
     TALER_LOG_WARNING ("Tip-pickup operation"

-- 
To stop receiving notification emails like this one, please contact
address@hidden