[GNUnet-SVN] [gnurl] 27/153: reuse_conn(): free old_conn->options

[gnunet]

This is an automated email from the git hooks/post-receive script.

ng0 pushed a commit to branch master
in repository gnurl.

commit a7091ba75d820612ec260da805e9148397eddfcd
Author: Even Rouault <address@hidden>
AuthorDate: Wed Jul 25 11:22:51 2018 +0200

    reuse_conn(): free old_conn->options
    
    This fixes a memory leak when CURLOPT_LOGIN_OPTIONS is used, together with
    connection reuse.
    
    I found this with oss-fuzz on GDAL and curl master:
    https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=9582
    I couldn't reproduce with the oss-fuzz original test case, but looking
    at curl source code pointed to this well reproducable leak.
    
    Closes #2790
---
 lib/url.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/url.c b/lib/url.c
index 5f520e91e..04f46b45f 100644
--- a/lib/url.c
+++ b/lib/url.c
@@ -3971,6 +3971,7 @@ static void reuse_conn(struct connectdata *old_conn,
 
   Curl_safefree(old_conn->user);
   Curl_safefree(old_conn->passwd);
+  Curl_safefree(old_conn->options);
   Curl_safefree(old_conn->http_proxy.user);
   Curl_safefree(old_conn->socks_proxy.user);
   Curl_safefree(old_conn->http_proxy.passwd);

-- 
To stop receiving notification emails like this one, please contact
address@hidden