[GNUnet-SVN] [gnunet] branch master updated: We want portable shell scripts, not plain bash-specific scripts.

[gnunet]

This is an automated email from the git hooks/post-receive script.

ng0 pushed a commit to branch master
in repository gnunet.

The following commit(s) were added to refs/heads/master by this push:
     new a3991d078 We want portable shell scripts, not plain bash-specific 
scripts.
a3991d078 is described below

commit a3991d078b2583cd09e58230333e8070a723e332
Author: Nils Gillmann <address@hidden>
AuthorDate: Sun Oct 21 18:49:41 2018 +0000

    We want portable shell scripts, not plain bash-specific scripts.
    
    Signed-off-by: Nils Gillmann <address@hidden>
---
 doc/documentation/chapters/contributing.texi | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/doc/documentation/chapters/contributing.texi 
b/doc/documentation/chapters/contributing.texi
index ed1c19b30..f4493e6c1 100644
--- a/doc/documentation/chapters/contributing.texi
+++ b/doc/documentation/chapters/contributing.texi
@@ -95,14 +95,23 @@ of languages, in order of preference:
 @enumerate
 @item C
 @item Portable Shell Scripts
address@hidden Bash Scripts
address@hidden Nim ?
 @item Python (@geq{}3.6)
 @end enumerate
 
 We welcome efforts to remove our existing python-2.7 scripts to
-replace them either with Bash or, at your choice, python-3.6+.
+replace them either with portable shell scripts or,
+at your choice, python-3.6+.
 
 If you contribute new python based testcases, we advise you to
 not repeat our past misfortunes and write the tests in a standard
 test framework like for example pytest.
+
+For writing portable shell scripts, these tools are useful:
address@hidden://github.com/koalaman/shellcheck, Shellcheck},
address@hidden://salsa.debian.org/debian/devscripts/blob/master/scripts/checkbashisms.pl,
 checkbashisms},
address@hidden://www.etalabs.net/sh_tricks.html},
address@hidden://wiki.ubuntu.com/DashAsBinSh},
+and @uref{https://mywiki.wooledge.org/Bashism}
+
address@hidden You could also run "bin/check_shell_script" (which we still have
address@hidden to write).

-- 
To stop receiving notification emails like this one, please contact
address@hidden