[GNUnet-SVN] [ascension] branch master updated: minor fixes

[gnunet]

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository ascension.

The following commit(s) were added to refs/heads/master by this push:
     new 72ef4b6  minor fixes
72ef4b6 is described below

commit 72ef4b6374aa75e0659476ed6e0a83140162d343
Author: Christian Grothoff <address@hidden>
AuthorDate: Wed May 1 15:13:44 2019 +0200

    minor fixes
---
 ascension/ascension.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/ascension/ascension.py b/ascension/ascension.py
index 4d521b4..d1492f8 100644
--- a/ascension/ascension.py
+++ b/ascension/ascension.py
@@ -269,6 +269,8 @@ class Ascender():
         # Check if there is zone has already been migrated
         nsrecords = cls.zone.iterate_rdatas(dns.rdatatype.NS)
 
+        # This is broken if your NS is for ns.foo.YOURZONE as you add
+        # the PKEY to YOURZONE instead of to the foo.YOURZONE subzone.
         gnspkey = list(filter(lambda record: 
str(record[2]).startswith('gns--pkey--'), nsrecords))
         if gnspkey:
             label = str(gnspkey[0][0])
@@ -342,8 +344,7 @@ class Ascender():
             logging.critical("thread join timed out, still running")
 
         # Add soa record to GNS once completed (updates the previous one)
-        soa = cls.get_zone_soa(cls.zone)
-        cls.add_soa_record_to_gns(soa)
+        cls.add_soa_record_to_gns(cls.soa)
         logging.info("All records have been added!")
 
     @staticmethod

-- 
To stop receiving notification emails like this one, please contact
address@hidden