[gnurl] 206/222: schannel_verify: Fix concurrent openings of CA file

[gnunet]

This is an automated email from the git hooks/post-receive script.

ng0 pushed a commit to branch master
in repository gnurl.

commit 9c49824902834bb12e26e66f4a8db74f4b9ea217
Author: Jay Satiro <address@hidden>
AuthorDate: Fri Nov 1 18:02:59 2019 -0400

    schannel_verify: Fix concurrent openings of CA file
    
    - Open the CA file using FILE_SHARE_READ mode so that others can read
      from it as well.
    
    Prior to this change our schannel code opened the CA file without
    sharing which meant concurrent openings (eg an attempt from another
    thread or process) would fail during the time it was open without
    sharing, which in curl's case would cause error:
    "schannel: failed to open CA file".
    
    Bug: https://curl.haxx.se/mail/lib-2019-10/0104.html
    Reported-by: Richard Alcock
---
 lib/vtls/schannel_verify.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/vtls/schannel_verify.c b/lib/vtls/schannel_verify.c
index 5a09e969e..1bdf50a55 100644
--- a/lib/vtls/schannel_verify.c
+++ b/lib/vtls/schannel_verify.c
@@ -111,7 +111,7 @@ static CURLcode add_certs_to_store(HCERTSTORE trust_store,
    */
   ca_file_handle = CreateFile(ca_file_tstr,
                               GENERIC_READ,
-                              0,
+                              FILE_SHARE_READ,
                               NULL,
                               OPEN_EXISTING,
                               FILE_ATTRIBUTE_NORMAL,

-- 
To stop receiving notification emails like this one, please contact
address@hidden.