[gnurl] 116/151: curl: improved cleanup in upload error path

[gnunet]

This is an automated email from the git hooks/post-receive script.

ng0 pushed a commit to branch master
in repository gnurl.

commit dc4900eea7317c67116fd5e6cd31863775da88ed
Author: Daniel Stenberg <address@hidden>
AuthorDate: Wed Dec 11 11:16:12 2019 +0100

    curl: improved cleanup in upload error path
    
    Memory leak found by torture test 58
    
    Closes #4705
---
 src/tool_operhlp.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/src/tool_operhlp.c b/src/tool_operhlp.c
index 543bf4302..8a9b7c9e8 100644
--- a/src/tool_operhlp.c
+++ b/src/tool_operhlp.c
@@ -115,16 +115,17 @@ char *add_file_name_to_url(char *url, const char 
*filename)
         urlbuffer = aprintf("%s/%s", url, encfile);
 
       curl_free(encfile);
-      Curl_safefree(url);
 
-      if(!urlbuffer)
-        return NULL;
+      if(!urlbuffer) {
+        url = NULL;
+        goto end;
+      }
 
+      Curl_safefree(url);
       url = urlbuffer; /* use our new URL instead! */
     }
-    else
-      Curl_safefree(url);
   }
+  end:
   curl_easy_cleanup(curl);
   return url;
 }

-- 
To stop receiving notification emails like this one, please contact
address@hidden.