[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[gnunet] 10/25: some comments
From: |
gnunet |
Subject: |
[gnunet] 10/25: some comments |
Date: |
Mon, 13 Jan 2020 13:46:55 +0100 |
This is an automated email from the git hooks/post-receive script.
martin-schanzenbach pushed a commit to branch master
in repository gnunet.
commit c136a16600cd4f72d7def1af7b4aa7592310c898
Author: Schanzenbach, Martin <address@hidden>
AuthorDate: Thu Oct 17 17:07:05 2019 +0200
some comments
---
src/include/gnunet_reclaim_attribute_lib.h | 6 ++++++
src/include/gnunet_reclaim_attribute_plugin.h | 10 ++++++++--
2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/src/include/gnunet_reclaim_attribute_lib.h
b/src/include/gnunet_reclaim_attribute_lib.h
index 34429da51..8476e77fc 100644
--- a/src/include/gnunet_reclaim_attribute_lib.h
+++ b/src/include/gnunet_reclaim_attribute_lib.h
@@ -348,6 +348,12 @@ GNUNET_RECLAIM_ATTRIBUTE_number_to_typename (uint32_t
type);
/**
* Get required size for serialization buffer
+ * FIXME:
+ * 1. The naming convention is violated here.
+ * It should GNUNET_RECLAIM_ATTRIBUTE_<lowercase from here>.
+ * It might make sense to refactor attestations into a separate folder.
+ * 2. The struct should be called GNUNET_RECLAIM_ATTESTATION_Data or
+ * GNUNET_RECLAIM_ATTRIBUTE_Attestation depending on location in source.
*
* @param attr the attestation to serialize
* @return the required buffer size
diff --git a/src/include/gnunet_reclaim_attribute_plugin.h
b/src/include/gnunet_reclaim_attribute_plugin.h
index bdd815dcf..e61cca5b2 100644
--- a/src/include/gnunet_reclaim_attribute_plugin.h
+++ b/src/include/gnunet_reclaim_attribute_plugin.h
@@ -136,8 +136,14 @@ struct GNUNET_RECLAIM_ATTRIBUTE_PluginFunctions
GNUNET_RECLAIM_ATTRIBUTE_NumberToTypenameFunction number_to_typename;
/**
-* Attestation Conversion to string.
-*/
+ * FIXME: It is odd that attestation functions are withing the attribute
+ * plugin. An attribute type may be backed by an attestation, but not
+ * necessarily.
+ * Maybe it would make more sense to refactor this into an attestation
+ * plugin?
+ *
+ * Attestation Conversion to string.
+ */
GNUNET_RECLAIM_ATTRIBUTE_ValueToStringFunction value_to_string_attest;
/**
--
To stop receiving notification emails like this one, please contact
address@hidden.
- [gnunet] branch master updated (c0a6838a1 -> e52520756), gnunet, 2020/01/13
- [gnunet] 03/25: Initial Fixes of plugin, gnunet, 2020/01/13
- [gnunet] 01/25: Adapted Namestore and reclaim REST, gnunet, 2020/01/13
- [gnunet] 02/25: Adapted JSON Conversion and Serialization, gnunet, 2020/01/13
- [gnunet] 04/25: Fixed direct Namestore Access, gnunet, 2020/01/13
- [gnunet] 05/25: Direct Namestore Deletion Implemented, gnunet, 2020/01/13
- [gnunet] 06/25: Add Attestations via Reclaim Service, gnunet, 2020/01/13
- [gnunet] 07/25: Delete Attestation via Service, gnunet, 2020/01/13
- [gnunet] 08/25: Prepare Listing Attestations, gnunet, 2020/01/13
- [gnunet] 10/25: some comments,
gnunet <=
- [gnunet] 09/25: Listing Attestations through service, gnunet, 2020/01/13
- [gnunet] 11/25: Preparation for Reference Type, gnunet, 2020/01/13
- [gnunet] 12/25: Adding Reference Type Implemented, gnunet, 2020/01/13
- [gnunet] 13/25: Deletion of Reference Type, gnunet, 2020/01/13
- [gnunet] 14/25: Fixed Reference Deletion, gnunet, 2020/01/13
- [gnunet] 16/25: Listing of References with Attributes, gnunet, 2020/01/13
- [gnunet] 17/25: Pure Listing of References, gnunet, 2020/01/13
- [gnunet] 15/25: Prepared Listing of References, gnunet, 2020/01/13
- [gnunet] 18/25: Prepared JWT Plugin, gnunet, 2020/01/13
- [gnunet] 20/25: JWT Plugin, Prepared Ticketing, gnunet, 2020/01/13