[taler-exchange] branch master updated: abort wire audit if bank fails to return histories

[gnunet]

This is an automated email from the git hooks/post-receive script.

grothoff pushed a commit to branch master
in repository exchange.

The following commit(s) were added to refs/heads/master by this push:
     new 1759b63b abort wire audit if bank fails to return histories
1759b63b is described below

commit 1759b63b2f0df1b794ed73f614b60493977d3e74
Author: Christian Grothoff <address@hidden>
AuthorDate: Fri Jan 17 15:13:27 2020 +0100

    abort wire audit if bank fails to return histories
---
 src/auditor/taler-wire-auditor.c | 26 ++++++++++++++++++--------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/src/auditor/taler-wire-auditor.c b/src/auditor/taler-wire-auditor.c
index 7a44417d..fff0e95b 100644
--- a/src/auditor/taler-wire-auditor.c
+++ b/src/auditor/taler-wire-auditor.c
@@ -1358,14 +1358,19 @@ history_debit_cb (void *cls,
 
   if (NULL == details)
   {
+    wa->dhh = NULL;
     if (TALER_EC_NONE != ec)
     {
-      /* FIXME: log properly to audit report! */
-      GNUNET_log (GNUNET_ERROR_TYPE_INFO,
-                  "Error fetching history: %u!\n",
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                  "Error fetching debit history of account %s: %u/%u!\n",
+                  wa->section_name,
+                  http_status_code,
                   (unsigned int) ec);
+      commit (GNUNET_DB_STATUS_HARD_ERROR);
+      global_ret = 1;
+      GNUNET_SCHEDULER_shutdown ();
+      return GNUNET_SYSERR;
     }
-    wa->dhh = NULL;
     check_exchange_wire_out (wa);
     return GNUNET_OK;
   }
@@ -1629,15 +1634,20 @@ history_credit_cb (void *cls,
 
   if (NULL == details)
   {
+    wa->chh = NULL;
     if (TALER_EC_NONE != ec)
     {
-      /* FIXME: log properly to audit report! */
-      GNUNET_log (GNUNET_ERROR_TYPE_INFO,
-                  "Error fetching history: %u!\n",
+      GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
+                  "Error fetching credit history of account %s: %u/%u!\n",
+                  wa->section_name,
+                  http_status,
                   (unsigned int) ec);
+      commit (GNUNET_DB_STATUS_HARD_ERROR);
+      global_ret = 1;
+      GNUNET_SCHEDULER_shutdown ();
+      return GNUNET_SYSERR;
     }
     /* end of operation */
-    wa->chh = NULL;
     GNUNET_log (GNUNET_ERROR_TYPE_INFO,
                 "Reconciling CREDIT processing of account `%s'\n",
                 wa->section_name);

-- 
To stop receiving notification emails like this one, please contact
address@hidden.