gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[libeufin] branch master updated: comments


From: gnunet
Subject: [libeufin] branch master updated: comments
Date: Wed, 12 Feb 2020 18:50:54 +0100

This is an automated email from the git hooks/post-receive script.

marcello pushed a commit to branch master
in repository libeufin.

The following commit(s) were added to refs/heads/master by this push:
     new 9632ba7  comments
9632ba7 is described below

commit 9632ba7c7d358fc714c1cc65af1a9b9fcf054f88
Author: Marcello Stanisci <address@hidden>
AuthorDate: Wed Feb 12 18:50:47 2020 +0100

    comments
---
 nexus/src/main/kotlin/tech/libeufin/nexus/Main.kt | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/nexus/src/main/kotlin/tech/libeufin/nexus/Main.kt 
b/nexus/src/main/kotlin/tech/libeufin/nexus/Main.kt
index c2d9dbd..809bd9a 100644
--- a/nexus/src/main/kotlin/tech/libeufin/nexus/Main.kt
+++ b/nexus/src/main/kotlin/tech/libeufin/nexus/Main.kt
@@ -290,10 +290,6 @@ fun main() {
                 }
             }
 
-            post("/ebics/subscribers/fetch-accounts") {
-                // FIXME(marcello): fetch accounts via HTD and store it in the 
database
-            }
-
             get("/ebics/subscribers/{id}/accounts") {
                 // FIXME(marcello): return bank accounts associated with the 
subscriber,
                 // this information is only avaiable *after* HTD or HKD has 
been called
@@ -444,9 +440,10 @@ fun main() {
                         }
                         transaction {
                             val subscriber = 
EbicsSubscriberEntity.findById(customerIdAtNexus)
+                            // FIXME: see if "!!" can be avoided
                             
payload.value.partnerInfo.accountInfoList!!.forEach {
                                 EbicsAccountInfoEntity.new {
-                                    this.subscriber = subscriber!! /* Checked 
at the beginning of this function */
+                                    this.subscriber = subscriber!! /* FIXME: 
Always true here, but to be avoided */
                                     accountId = it.id
                                     accountHolder = it.accountHolder
                                     /* FIXME: how to figure out whether that's 
a general or national account number? */

-- 
To stop receiving notification emails like this one, please contact
address@hidden.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]