[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[taler-merchant-terminal-android] 19/19: Check for duplicate product IDs
From: |
gnunet |
Subject: |
[taler-merchant-terminal-android] 19/19: Check for duplicate product IDs |
Date: |
Fri, 21 Feb 2020 19:00:12 +0100 |
This is an automated email from the git hooks/post-receive script.
torsten-grote pushed a commit to branch master
in repository merchant-terminal-android.
commit 39af919b68c2b9a50eb39b20838321c8d730dbcd
Author: Torsten Grote <address@hidden>
AuthorDate: Thu Feb 20 17:15:40 2020 -0300
Check for duplicate product IDs
---
app/src/main/java/net/taler/merchantpos/order/OrderManager.kt | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/app/src/main/java/net/taler/merchantpos/order/OrderManager.kt
b/app/src/main/java/net/taler/merchantpos/order/OrderManager.kt
index 1ff04d8..d7db048 100644
--- a/app/src/main/java/net/taler/merchantpos/order/OrderManager.kt
+++ b/app/src/main/java/net/taler/merchantpos/order/OrderManager.kt
@@ -68,12 +68,18 @@ class OrderManager(private val mapper: ObjectMapper) :
ConfigurationReceiver {
// group products by categories
productsByCategory.clear()
+ val seenIds = ArrayList<String>()
products.forEach { product ->
val productCurrency = fromString(product.price).currency
if (productCurrency != currency) {
Log.e(TAG, "Product $product has currency $productCurrency,
$currency expected")
return false
}
+ if (seenIds.contains(product.id)) {
+ Log.e(TAG, "Product $product has duplicate product_id
${product.id}")
+ return false
+ }
+ seenIds.add(product.id)
product.categories.forEach { categoryId ->
val category = categories.find { it.id == categoryId }
if (category == null) {
--
To stop receiving notification emails like this one, please contact
address@hidden.
- [taler-merchant-terminal-android] 06/19: Create payments directly from the order, (continued)
- [taler-merchant-terminal-android] 06/19: Create payments directly from the order, gnunet, 2020/02/21
- [taler-merchant-terminal-android] 04/19: Fetch merchant config from central configuration JSON, gnunet, 2020/02/21
- [taler-merchant-terminal-android] 02/19: Add screen to process an order, gnunet, 2020/02/21
- [taler-merchant-terminal-android] 18/19: Don't talk about NFC if it is not supported, gnunet, 2020/02/21
- [taler-merchant-terminal-android] 14/19: Use product categories for order summary, gnunet, 2020/02/21
- [taler-merchant-terminal-android] 11/19: Allow user to decide if they want to save password, add FORGET option, gnunet, 2020/02/21
- [taler-merchant-terminal-android] 13/19: Make NFC and QR code re-useable in another app, gnunet, 2020/02/21
- [taler-merchant-terminal-android] 15/19: Introduce different product classes for re-use in other taler apps, gnunet, 2020/02/21
- [taler-merchant-terminal-android] 17/19: Make order sorting deterministic, gnunet, 2020/02/21
- [taler-merchant-terminal-android] 12/19: Fix invalid product configuration, gnunet, 2020/02/21
- [taler-merchant-terminal-android] 19/19: Check for duplicate product IDs,
gnunet <=
- [taler-merchant-terminal-android] 10/19: Require valid configuration before showing UI, gnunet, 2020/02/21
- [taler-merchant-terminal-android] 16/19: Allow editing order with -1 and +1 buttons, gnunet, 2020/02/21