gnunet-svn
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[gnurl] 31/264: tool_operate: fix add_parallel_transfers when more are i


From: gnunet
Subject: [gnurl] 31/264: tool_operate: fix add_parallel_transfers when more are in queue
Date: Thu, 30 Apr 2020 16:05:34 +0200

This is an automated email from the git hooks/post-receive script.

nikita pushed a commit to branch master
in repository gnurl.

commit 95c36fff75883ace6e8e7a89b94362de2dd1857f
Author: Daniel Stenberg <address@hidden>
AuthorDate: Mon Mar 16 09:33:27 2020 +0100

    tool_operate: fix add_parallel_transfers when more are in queue
    
    Trying to return early from the function if no new transfers were added
    would break the "morep" argument and cause issues. This could lead to
    zero content "transfers" (within quotes since they would never be
    started) when parallel-max was reduced.
    
    Reported-by: Gavin Wong
    Analyzed-by: Jay Satiro
    Fixes #4937
    Closes #5112
---
 src/tool_operate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/tool_operate.c b/src/tool_operate.c
index 4b3caa80c..ab06b71c5 100644
--- a/src/tool_operate.c
+++ b/src/tool_operate.c
@@ -2055,7 +2055,7 @@ static CURLcode add_parallel_transfers(struct 
GlobalConfig *global,
   *addedp = FALSE;
   *morep = FALSE;
   result = create_transfer(global, share, addedp);
-  if(result || !*addedp)
+  if(result)
     return result;
   for(per = transfers; per && (all_added < global->parallel_max);
       per = per->next) {

-- 
To stop receiving notification emails like this one, please contact
address@hidden.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]