[libeufin] 02/02: do not leak HTTP client

[gnunet]

This is an automated email from the git hooks/post-receive script.

dold pushed a commit to branch master
in repository libeufin.

commit e50a6fc32e4c15cb27f9d87f896209255ce63bb7
Author: Florian Dold <florian.dold@gmail.com>
AuthorDate: Tue Jun 16 19:20:40 2020 +0530

    do not leak HTTP client
---
 nexus/src/main/kotlin/tech/libeufin/nexus/Main.kt  | 2 +-
 nexus/src/main/kotlin/tech/libeufin/nexus/taler.kt | 7 +++----
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/nexus/src/main/kotlin/tech/libeufin/nexus/Main.kt 
b/nexus/src/main/kotlin/tech/libeufin/nexus/Main.kt
index 80b9e43..3b2a0fd 100644
--- a/nexus/src/main/kotlin/tech/libeufin/nexus/Main.kt
+++ b/nexus/src/main/kotlin/tech/libeufin/nexus/Main.kt
@@ -853,7 +853,7 @@ fun serverMain(dbName: String) {
             }
 
             route("/facades/{fcid}/taler") {
-                talerFacadeRoutes(this)
+                talerFacadeRoutes(this, client)
             }
             /**
              * Hello endpoint.
diff --git a/nexus/src/main/kotlin/tech/libeufin/nexus/taler.kt 
b/nexus/src/main/kotlin/tech/libeufin/nexus/taler.kt
index 9e78f33..11ca8a9 100644
--- a/nexus/src/main/kotlin/tech/libeufin/nexus/taler.kt
+++ b/nexus/src/main/kotlin/tech/libeufin/nexus/taler.kt
@@ -327,7 +327,7 @@ private suspend fun talerTransfer(call: ApplicationCall) {
 }
 
 // /taler/admin/add-incoming
-private suspend fun talerAddIncoming(call: ApplicationCall): Unit {
+private suspend fun talerAddIncoming(call: ApplicationCall, httpClient: 
HttpClient): Unit {
     val addIncomingData = call.receive<TalerAdminAddIncoming>()
     val debtor = parsePayto(addIncomingData.debit_account)
     val res = transaction {
@@ -342,7 +342,6 @@ private suspend fun talerAddIncoming(call: 
ApplicationCall): Unit {
             val facadeHolderName = facadeBankAccount.accountHolder
         }
     }
-    val httpClient = HttpClient()
     /** forward the payment information to the sandbox.  */
     httpClient.post<String>(
         urlString = "http://localhost:5000/admin/payments";,
@@ -629,13 +628,13 @@ private suspend fun historyIncoming(call: 
ApplicationCall): Unit {
     return call.respond(TextContent(customConverter(history), 
ContentType.Application.Json))
 }
 
-fun talerFacadeRoutes(route: Route) {
+fun talerFacadeRoutes(route: Route, httpClient: HttpClient) {
     route.post("/transfer") {
         talerTransfer(call)
         return@post
     }
     route.post("/admin/add-incoming") {
-        talerAddIncoming(call)
+        talerAddIncoming(call, httpClient)
         return@post
     }
     route.get("/history/outgoing") {

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.