[taler-deployment] branch master updated: moved create_factory_with_deployment function above declarations

[gnunet]

This is an automated email from the git hooks/post-receive script.

buck pushed a commit to branch master
in repository deployment.

The following commit(s) were added to refs/heads/master by this push:
     new aec67d1  moved create_factory_with_deployment function above 
declarations
aec67d1 is described below

commit aec67d1d9af4dc155d759571f5ec69138fd1dcc4
Author: buckE <buckE@disroot.org>
AuthorDate: Wed Jun 17 05:31:41 2020 +0000

    moved create_factory_with_deployment function above declarations
---
 buildbot/master.cfg                                       | 15 +++++++++------
 .../{master.cfg => master.cfg.BACK-movingFunctionsAround} |  3 ++-
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/buildbot/master.cfg b/buildbot/master.cfg
index 52471de..aa16993 100644
--- a/buildbot/master.cfg
+++ b/buildbot/master.cfg
@@ -37,14 +37,22 @@ c = BuildmasterConfig = {}
 # Silence warning and allow very basic phoning home.
 c["buildbotNetUsageData"] = "basic"
 
+
+# Create a FACTORY with a deployment.git checkout as the first step.
+def create_factory_with_deployment():
+    f = util.BuildFactory()
+    update_deployment (f);
+    return f
+
 
###########################################################################################
 # ------------- NEW FORMATTING STARTS HERE FOR NEW AND MODIFIED PROJECTS 
-----------------
 
+# !!! This matters.  Mis-ordering leads to failure. !!!
 # Best Practices:  Group by worker as:
 #  - comment for worker location (ex: "Find worker at: xyz shell account non 
taler.net")
 #  - SCHEDULER
-#  - BUILDER function
 #  - FACTORY function
+#  - BUILDER function
 #
 # NOTE: WORKER must be added to list: c["workers"] = [
 # NOTE: BUILDER must be added to list: c["builders"] = [
@@ -443,11 +451,6 @@ def update_deployment(factory):
         workdir="../.."
     ))
 
-# Create a FACTORY with a deployment.git checkout as the first step.
-def create_factory_with_deployment():
-    f = util.BuildFactory()
-    update_deployment (f);
-    return f
 
 # Factory to update the buildmaster itself.
 BUILDMASTER_FACTORY = create_factory_with_deployment()
diff --git a/buildbot/master.cfg 
b/buildbot/master.cfg.BACK-movingFunctionsAround
similarity index 99%
copy from buildbot/master.cfg
copy to buildbot/master.cfg.BACK-movingFunctionsAround
index 52471de..c40a6c5 100644
--- a/buildbot/master.cfg
+++ b/buildbot/master.cfg.BACK-movingFunctionsAround
@@ -40,11 +40,12 @@ c["buildbotNetUsageData"] = "basic"
 
###########################################################################################
 # ------------- NEW FORMATTING STARTS HERE FOR NEW AND MODIFIED PROJECTS 
-----------------
 
+# !!! This matters.  Mis-ordering leads to failure. !!!
 # Best Practices:  Group by worker as:
 #  - comment for worker location (ex: "Find worker at: xyz shell account non 
taler.net")
 #  - SCHEDULER
-#  - BUILDER function
 #  - FACTORY function
+#  - BUILDER function
 #
 # NOTE: WORKER must be added to list: c["workers"] = [
 # NOTE: BUILDER must be added to list: c["builders"] = [

-- 
To stop receiving notification emails like this one, please contact
gnunet@gnunet.org.